* [Qemu-devel] Guest agent does not build on OpenBSD
@ 2011-07-22 18:28 Blue Swirl
2011-07-22 19:00 ` Brad
0 siblings, 1 reply; 4+ messages in thread
From: Blue Swirl @ 2011-07-22 18:28 UTC (permalink / raw)
To: Michael Roth, Luiz Capitulino, qemu-devel
I get these errors on OpenBSD:
CC qga/guest-agent-commands.o
/src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such
file or directory
/src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No
such file or directory
In file included from /src/qemu/qga/guest-agent-commands.c:19:
qapi-generated/qga-qmp-commands.h:36:7: warning: no newline at end of file
/src/qemu/qga/guest-agent-commands.c: In function
'guest_fsfreeze_build_mount_list':
/src/qemu/qga/guest-agent-commands.c:344: error: 'MOUNTED' undeclared
(first use in this function)
/src/qemu/qga/guest-agent-commands.c:344: error: (Each undeclared
identifier is reported only once
/src/qemu/qga/guest-agent-commands.c:344: error: for each function it
appears in.)
/src/qemu/qga/guest-agent-commands.c:354: warning: implicit
declaration of function 'setmntent'
/src/qemu/qga/guest-agent-commands.c:354: warning: nested extern
declaration of 'setmntent'
/src/qemu/qga/guest-agent-commands.c:354: warning: assignment makes
pointer from integer without a cast
/src/qemu/qga/guest-agent-commands.c:360: warning: implicit
declaration of function 'getmntent'
/src/qemu/qga/guest-agent-commands.c:360: warning: nested extern
declaration of 'getmntent'
/src/qemu/qga/guest-agent-commands.c:360: warning: assignment makes
pointer from integer without a cast
/src/qemu/qga/guest-agent-commands.c:367: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:368: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:369: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:374: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:375: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:380: warning: implicit
declaration of function 'endmntent'
/src/qemu/qga/guest-agent-commands.c:380: warning: nested extern
declaration of 'endmntent'
/src/qemu/qga/guest-agent-commands.c: In function 'qmp_guest_fsfreeze_freeze':
/src/qemu/qga/guest-agent-commands.c:436: error: 'FIFREEZE' undeclared
(first use in this function)
/src/qemu/qga/guest-agent-commands.c: In function 'qmp_guest_fsfreeze_thaw':
/src/qemu/qga/guest-agent-commands.c:474: error: 'FITHAW' undeclared
(first use in this function)
Maybe guest agent should be only built on supported hosts.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] Guest agent does not build on OpenBSD
2011-07-22 18:28 [Qemu-devel] Guest agent does not build on OpenBSD Blue Swirl
@ 2011-07-22 19:00 ` Brad
2011-07-22 19:05 ` Anthony Liguori
2011-07-24 13:14 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Brad @ 2011-07-22 19:00 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel, Michael Roth, Luiz Capitulino
On 22/07/11 2:28 PM, Blue Swirl wrote:
> I get these errors on OpenBSD:
> CC qga/guest-agent-commands.o
> /src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such
> file or directory
> /src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No
> such file or directory
> In file included from /src/qemu/qga/guest-agent-commands.c:19:
> qapi-generated/qga-qmp-commands.h:36:7: warning: no newline at end of file
> /src/qemu/qga/guest-agent-commands.c: In function
> 'guest_fsfreeze_build_mount_list':
> /src/qemu/qga/guest-agent-commands.c:344: error: 'MOUNTED' undeclared
> (first use in this function)
> /src/qemu/qga/guest-agent-commands.c:344: error: (Each undeclared
> identifier is reported only once
> /src/qemu/qga/guest-agent-commands.c:344: error: for each function it
> appears in.)
> /src/qemu/qga/guest-agent-commands.c:354: warning: implicit
> declaration of function 'setmntent'
> /src/qemu/qga/guest-agent-commands.c:354: warning: nested extern
> declaration of 'setmntent'
> /src/qemu/qga/guest-agent-commands.c:354: warning: assignment makes
> pointer from integer without a cast
> /src/qemu/qga/guest-agent-commands.c:360: warning: implicit
> declaration of function 'getmntent'
> /src/qemu/qga/guest-agent-commands.c:360: warning: nested extern
> declaration of 'getmntent'
> /src/qemu/qga/guest-agent-commands.c:360: warning: assignment makes
> pointer from integer without a cast
> /src/qemu/qga/guest-agent-commands.c:367: error: dereferencing pointer
> to incomplete type
> /src/qemu/qga/guest-agent-commands.c:368: error: dereferencing pointer
> to incomplete type
> /src/qemu/qga/guest-agent-commands.c:369: error: dereferencing pointer
> to incomplete type
> /src/qemu/qga/guest-agent-commands.c:374: error: dereferencing pointer
> to incomplete type
> /src/qemu/qga/guest-agent-commands.c:375: error: dereferencing pointer
> to incomplete type
> /src/qemu/qga/guest-agent-commands.c:380: warning: implicit
> declaration of function 'endmntent'
> /src/qemu/qga/guest-agent-commands.c:380: warning: nested extern
> declaration of 'endmntent'
> /src/qemu/qga/guest-agent-commands.c: In function 'qmp_guest_fsfreeze_freeze':
> /src/qemu/qga/guest-agent-commands.c:436: error: 'FIFREEZE' undeclared
> (first use in this function)
> /src/qemu/qga/guest-agent-commands.c: In function 'qmp_guest_fsfreeze_thaw':
> /src/qemu/qga/guest-agent-commands.c:474: error: 'FITHAW' undeclared
> (first use in this function)
>
> Maybe guest agent should be only built on supported hosts.
*sigh* This was some pretty sloppy work that was commited with very
little testing. The QAPI stuff that was commited also needs Python
to build and no appropriate checks were added to the configure script
to check for its presence and to allow the person building to point
to appropriate Python binary instead of a hardcoded binary name in the
Makefile.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] Guest agent does not build on OpenBSD
2011-07-22 19:00 ` Brad
@ 2011-07-22 19:05 ` Anthony Liguori
2011-07-24 13:14 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2011-07-22 19:05 UTC (permalink / raw)
To: Brad; +Cc: Blue Swirl, Luiz Capitulino, qemu-devel, Michael Roth
On 07/22/2011 02:00 PM, Brad wrote:
> On 22/07/11 2:28 PM, Blue Swirl wrote:
>> I get these errors on OpenBSD:
>> CC qga/guest-agent-commands.o
>> /src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such
>> file or directory
>> /src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No
>> such file or directory
>> In file included from /src/qemu/qga/guest-agent-commands.c:19:
>> qapi-generated/qga-qmp-commands.h:36:7: warning: no newline at end of
>> file
>> /src/qemu/qga/guest-agent-commands.c: In function
>> 'guest_fsfreeze_build_mount_list':
>> /src/qemu/qga/guest-agent-commands.c:344: error: 'MOUNTED' undeclared
>> (first use in this function)
>> /src/qemu/qga/guest-agent-commands.c:344: error: (Each undeclared
>> identifier is reported only once
>> /src/qemu/qga/guest-agent-commands.c:344: error: for each function it
>> appears in.)
>> /src/qemu/qga/guest-agent-commands.c:354: warning: implicit
>> declaration of function 'setmntent'
>> /src/qemu/qga/guest-agent-commands.c:354: warning: nested extern
>> declaration of 'setmntent'
>> /src/qemu/qga/guest-agent-commands.c:354: warning: assignment makes
>> pointer from integer without a cast
>> /src/qemu/qga/guest-agent-commands.c:360: warning: implicit
>> declaration of function 'getmntent'
>> /src/qemu/qga/guest-agent-commands.c:360: warning: nested extern
>> declaration of 'getmntent'
>> /src/qemu/qga/guest-agent-commands.c:360: warning: assignment makes
>> pointer from integer without a cast
>> /src/qemu/qga/guest-agent-commands.c:367: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:368: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:369: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:374: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:375: error: dereferencing pointer
>> to incomplete type
>> /src/qemu/qga/guest-agent-commands.c:380: warning: implicit
>> declaration of function 'endmntent'
>> /src/qemu/qga/guest-agent-commands.c:380: warning: nested extern
>> declaration of 'endmntent'
>> /src/qemu/qga/guest-agent-commands.c: In function
>> 'qmp_guest_fsfreeze_freeze':
>> /src/qemu/qga/guest-agent-commands.c:436: error: 'FIFREEZE' undeclared
>> (first use in this function)
>> /src/qemu/qga/guest-agent-commands.c: In function
>> 'qmp_guest_fsfreeze_thaw':
>> /src/qemu/qga/guest-agent-commands.c:474: error: 'FITHAW' undeclared
>> (first use in this function)
>>
>> Maybe guest agent should be only built on supported hosts.
>
> *sigh* This was some pretty sloppy work that was commited with very
> little testing. The QAPI stuff that was commited also needs Python
> to build and no appropriate checks were added to the configure script
> to check for its presence and to allow the person building to point
> to appropriate Python binary instead of a hardcoded binary name in the
> Makefile.
>
Patches are certainly welcome.
Python in taken from path so you can certainly overload it.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] Guest agent does not build on OpenBSD
2011-07-22 19:00 ` Brad
2011-07-22 19:05 ` Anthony Liguori
@ 2011-07-24 13:14 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2011-07-24 13:14 UTC (permalink / raw)
To: Brad; +Cc: Blue Swirl, Daniel Gollub, Luiz Capitulino, qemu-devel,
Michael Roth
On Fri, Jul 22, 2011 at 8:00 PM, Brad <brad@comstyle.com> wrote:
> *sigh* This was some pretty sloppy work that was commited with very little
> testing. The QAPI stuff that was commited also needs Python
> to build and no appropriate checks were added to the configure script
> to check for its presence and to allow the person building to point
> to appropriate Python binary instead of a hardcoded binary name in the
> Makefile.
The best defense against build breakages and bitrot is the buildbot
that runs daily builds and reports errors. These builds are now
include maintainer trees (e.g. Kevin's block tree and Michael
Tsirkin's pci tree) - that means broken patches will be weeded out
before they are merged into qemu.git/master.
The level of coverage depends on volunteers adding machines for host
OSes they care about. For example, we're missing *BSD and Windows
(even mingw cross-compile).
Do you want to add a buildslave to cover the host you care about? For
more info:
http://wiki.qemu.org/ContinuousIntegration
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-24 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-22 18:28 [Qemu-devel] Guest agent does not build on OpenBSD Blue Swirl
2011-07-22 19:00 ` Brad
2011-07-22 19:05 ` Anthony Liguori
2011-07-24 13:14 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).