From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkL2n-0006yl-9c for qemu-devel@nongnu.org; Fri, 22 Jul 2011 15:05:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkL2m-0007Jn-96 for qemu-devel@nongnu.org; Fri, 22 Jul 2011 15:05:53 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:39759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkL2m-0007Jc-3v for qemu-devel@nongnu.org; Fri, 22 Jul 2011 15:05:52 -0400 Received: by gyf2 with SMTP id 2so1664731gyf.4 for ; Fri, 22 Jul 2011 12:05:51 -0700 (PDT) Message-ID: <4E29CA0C.1010101@codemonkey.ws> Date: Fri, 22 Jul 2011 14:05:48 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4E29C8C1.7000902@comstyle.com> In-Reply-To: <4E29C8C1.7000902@comstyle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Guest agent does not build on OpenBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Cc: Blue Swirl , Luiz Capitulino , qemu-devel , Michael Roth On 07/22/2011 02:00 PM, Brad wrote: > On 22/07/11 2:28 PM, Blue Swirl wrote: >> I get these errors on OpenBSD: >> CC qga/guest-agent-commands.o >> /src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such >> file or directory >> /src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No >> such file or directory >> In file included from /src/qemu/qga/guest-agent-commands.c:19: >> qapi-generated/qga-qmp-commands.h:36:7: warning: no newline at end of >> file >> /src/qemu/qga/guest-agent-commands.c: In function >> 'guest_fsfreeze_build_mount_list': >> /src/qemu/qga/guest-agent-commands.c:344: error: 'MOUNTED' undeclared >> (first use in this function) >> /src/qemu/qga/guest-agent-commands.c:344: error: (Each undeclared >> identifier is reported only once >> /src/qemu/qga/guest-agent-commands.c:344: error: for each function it >> appears in.) >> /src/qemu/qga/guest-agent-commands.c:354: warning: implicit >> declaration of function 'setmntent' >> /src/qemu/qga/guest-agent-commands.c:354: warning: nested extern >> declaration of 'setmntent' >> /src/qemu/qga/guest-agent-commands.c:354: warning: assignment makes >> pointer from integer without a cast >> /src/qemu/qga/guest-agent-commands.c:360: warning: implicit >> declaration of function 'getmntent' >> /src/qemu/qga/guest-agent-commands.c:360: warning: nested extern >> declaration of 'getmntent' >> /src/qemu/qga/guest-agent-commands.c:360: warning: assignment makes >> pointer from integer without a cast >> /src/qemu/qga/guest-agent-commands.c:367: error: dereferencing pointer >> to incomplete type >> /src/qemu/qga/guest-agent-commands.c:368: error: dereferencing pointer >> to incomplete type >> /src/qemu/qga/guest-agent-commands.c:369: error: dereferencing pointer >> to incomplete type >> /src/qemu/qga/guest-agent-commands.c:374: error: dereferencing pointer >> to incomplete type >> /src/qemu/qga/guest-agent-commands.c:375: error: dereferencing pointer >> to incomplete type >> /src/qemu/qga/guest-agent-commands.c:380: warning: implicit >> declaration of function 'endmntent' >> /src/qemu/qga/guest-agent-commands.c:380: warning: nested extern >> declaration of 'endmntent' >> /src/qemu/qga/guest-agent-commands.c: In function >> 'qmp_guest_fsfreeze_freeze': >> /src/qemu/qga/guest-agent-commands.c:436: error: 'FIFREEZE' undeclared >> (first use in this function) >> /src/qemu/qga/guest-agent-commands.c: In function >> 'qmp_guest_fsfreeze_thaw': >> /src/qemu/qga/guest-agent-commands.c:474: error: 'FITHAW' undeclared >> (first use in this function) >> >> Maybe guest agent should be only built on supported hosts. > > *sigh* This was some pretty sloppy work that was commited with very > little testing. The QAPI stuff that was commited also needs Python > to build and no appropriate checks were added to the configure script > to check for its presence and to allow the person building to point > to appropriate Python binary instead of a hardcoded binary name in the > Makefile. > Patches are certainly welcome. Python in taken from path so you can certainly overload it. Regards, Anthony Liguori