From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkNV3-000469-Co for qemu-devel@nongnu.org; Fri, 22 Jul 2011 17:43:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkNV2-0001aS-91 for qemu-devel@nongnu.org; Fri, 22 Jul 2011 17:43:13 -0400 Message-ID: <4E29EEEC.3090803@mail.berlios.de> Date: Fri, 22 Jul 2011 23:43:08 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1311190818-4793-1-git-send-email-weil@mail.berlios.de> <1A5A263C-4EFA-4BF5-AC6E-937D109C8DA7@web.de> In-Reply-To: <1A5A263C-4EFA-4BF5-AC6E-937D109C8DA7@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] darwin-user: Remove two unused variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-trivial@nongnu.org, QEMU Developers Am 22.07.2011 22:48, schrieb Andreas F=E4rber: > Hi Stefan W., > > Am 20.07.2011 um 21:40 schrieb Stefan Weil: > >> cppcheck report: >> >> darwin-user/signal.c:322: style: Unused variable: i >> darwin-user/signal.c:322: style: >> Variable 'err' is assigned a value that is never used > > Does this really bug you? I'm a bit skeptical towards trying to fix=20 > warnings in code that doesn't compile either way... (or does it by now?= ) > > Andreas Hi Andreas, the warnings were the result of a static code inspection with a program called cppcheck. I don't compile darwin code, so I did not notice that the code does not compile. Is there a good reason to keep those two unused variables? Fixing the issue helps with static code analysis because unnecessary manual code checks can be avoided. Cheers, Stefan