From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qkemh-0003Uy-1m for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:10:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qkemf-00007C-PZ for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:10:34 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:64478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qkemf-00006v-Ib for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:10:33 -0400 Received: by yxt3 with SMTP id 3so2053470yxt.4 for ; Sat, 23 Jul 2011 09:10:33 -0700 (PDT) Message-ID: <4E2AF277.6060001@codemonkey.ws> Date: Sat, 23 Jul 2011 11:10:31 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1311108115-27128-4-git-send-email-mdroth@linux.vnet.ibm.com> <1311193177-22282-1-git-send-email-mdroth@linux.vnet.ibm.com> <81810A74-E616-4199-BB69-E7DE4AAE9C0C@suse.de> <4E2AF189.7040403@linux.vnet.ibm.com> In-Reply-To: <4E2AF189.7040403@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, "qemu-devel@nongnu.org Developers" , Jes Sorensen , Alexander Graf , Luiz Capitulino , Blue Swirl , Anthony Liguori On 07/23/2011 11:06 AM, Michael Roth wrote: > On 07/23/2011 05:07 AM, Alexander Graf wrote: >> >> On 20.07.2011, at 22:19, Michael Roth wrote: >> >>> This is the actual guest daemon, it listens for requests over a >>> virtio-serial/isa-serial/unix socket channel and routes them through >>> to dispatch routines, and writes the results back to the channel in >>> a manner similar to QMP. >>> >>> A shorthand invocation: >>> >>> qemu-ga -d >>> >>> Is equivalent to: >>> >>> qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0 \ >>> -f /var/run/qemu-ga.pid -d >>> >>> Signed-off-by: Michael Roth >> >> A rebase on top of current HEAD gave me the following on openSUSE 11.1 >> PPC: >> >> >> agraf@lychee:/home/agraf/release/qemu> make >> CC qemu-ga.o >> qemu-ga.c:40: error: expected specifier-qualifier-list before ‘GSocket’ GIO is fairly new. It may not be available on openSUSE. Mike, you probably need to do a configure test for GIO and if it's not present, don't build qemu-ga. Maybe look at just using GIOChannels which have been around much longer than GSocket. >> qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_freeze’: >> qga/guest-agent-commands.c:443: error: ‘FIFREEZE’ undeclared (first >> use in this function) >> qga/guest-agent-commands.c:443: error: (Each undeclared identifier is >> reported only once >> qga/guest-agent-commands.c:443: error: for each function it appears in.) >> qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_thaw’: >> qga/guest-agent-commands.c:481: error: ‘FITHAW’ undeclared (first use >> in this function) The kernel probably doesn't implement FIFREEZE. You need to do a configure test and set CONFIG_FSFREEZE appropriately. I anticipated this and that's why I added CONFIG_FSFREEZE and didn't just do __linux__. Regards, Anthony Liguori