From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkfIb-0003O1-Kz for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:43:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkfIa-0005bO-Gb for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:43:33 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:34988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkfIa-0005bE-Dv for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:43:32 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6NGL2FI014957 for ; Sat, 23 Jul 2011 12:21:02 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6NGhR8n1319058 for ; Sat, 23 Jul 2011 12:43:27 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6NGhRvY018838 for ; Sat, 23 Jul 2011 12:43:27 -0400 Message-ID: <4E2AFA2D.9070706@linux.vnet.ibm.com> Date: Sat, 23 Jul 2011 11:43:25 -0500 From: Michael Roth MIME-Version: 1.0 References: <1311108115-27128-4-git-send-email-mdroth@linux.vnet.ibm.com> <1311193177-22282-1-git-send-email-mdroth@linux.vnet.ibm.com> <81810A74-E616-4199-BB69-E7DE4AAE9C0C@suse.de> <4E2AF189.7040403@linux.vnet.ibm.com> <4E2AF277.6060001@codemonkey.ws> In-Reply-To: <4E2AF277.6060001@codemonkey.ws> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: agl@linux.vnet.ibm.com, "qemu-devel@nongnu.org Developers" , Jes Sorensen , Alexander Graf , Luiz Capitulino , Blue Swirl , Anthony Liguori On 07/23/2011 11:10 AM, Anthony Liguori wrote: > On 07/23/2011 11:06 AM, Michael Roth wrote: >> On 07/23/2011 05:07 AM, Alexander Graf wrote: >>> >>> On 20.07.2011, at 22:19, Michael Roth wrote: >>> >>>> This is the actual guest daemon, it listens for requests over a >>>> virtio-serial/isa-serial/unix socket channel and routes them through >>>> to dispatch routines, and writes the results back to the channel in >>>> a manner similar to QMP. >>>> >>>> A shorthand invocation: >>>> >>>> qemu-ga -d >>>> >>>> Is equivalent to: >>>> >>>> qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0= \ >>>> -f /var/run/qemu-ga.pid -d >>>> >>>> Signed-off-by: Michael Roth >>> >>> A rebase on top of current HEAD gave me the following on openSUSE 11.= 1 >>> PPC: >>> >>> >>> agraf@lychee:/home/agraf/release/qemu> make >>> CC qemu-ga.o >>> qemu-ga.c:40: error: expected specifier-qualifier-list before =91GSoc= ket=92 > > GIO is fairly new. It may not be available on openSUSE. > > Mike, you probably need to do a configure test for GIO and if it's not > present, don't build qemu-ga. It should've failed the glib probe in that case. I think we might need a=20 compile test to catch this GSocket issue. Rather than building qemu-ga when possible, should we just go ahead and=20 add a configure option and only run the probes when it's set? At least=20 until QMP/QEMU start formally using glib? If so, on or off by default? > > Maybe look at just using GIOChannels which have been around much longer > than GSocket. > The GSocket stuff is being used in addition to GIOChannels to handle the=20 listen/accept stuff. I believe we can drop it in favor of=20 qemu-sockets.c/osdep.c though. >>> qga/guest-agent-commands.c: In function =91qmp_guest_fsfreeze_freeze=92= : >>> qga/guest-agent-commands.c:443: error: =91FIFREEZE=92 undeclared (fir= st >>> use in this function) >>> qga/guest-agent-commands.c:443: error: (Each undeclared identifier is >>> reported only once >>> qga/guest-agent-commands.c:443: error: for each function it appears i= n.) >>> qga/guest-agent-commands.c: In function =91qmp_guest_fsfreeze_thaw=92= : >>> qga/guest-agent-commands.c:481: error: =91FITHAW=92 undeclared (first= use >>> in this function) > > The kernel probably doesn't implement FIFREEZE. You need to do a > configure test and set CONFIG_FSFREEZE appropriately. I anticipated thi= s > and that's why I added CONFIG_FSFREEZE and didn't just do __linux__. > Will do, thanks. > Regards, > > Anthony Liguori