From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkfOv-0005J5-Fu for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkfOt-0006Zr-Ux for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:50:05 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:42169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkfOt-0006ZW-OB for qemu-devel@nongnu.org; Sat, 23 Jul 2011 12:50:03 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6NGZ11d010472 for ; Sat, 23 Jul 2011 10:35:01 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6NGncPm123296 for ; Sat, 23 Jul 2011 10:49:48 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6NAnAUm002852 for ; Sat, 23 Jul 2011 04:49:11 -0600 Message-ID: <4E2AFB9F.2010907@us.ibm.com> Date: Sat, 23 Jul 2011 11:49:35 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1311108115-27128-4-git-send-email-mdroth@linux.vnet.ibm.com> <1311193177-22282-1-git-send-email-mdroth@linux.vnet.ibm.com> <81810A74-E616-4199-BB69-E7DE4AAE9C0C@suse.de> <4E2AF189.7040403@linux.vnet.ibm.com> <4E2AF277.6060001@codemonkey.ws> <4E2AFA2D.9070706@linux.vnet.ibm.com> In-Reply-To: <4E2AFA2D.9070706@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, "qemu-devel@nongnu.org Developers" , Jes Sorensen , Alexander Graf , Luiz Capitulino , Blue Swirl , Anthony Liguori On 07/23/2011 11:43 AM, Michael Roth wrote: > On 07/23/2011 11:10 AM, Anthony Liguori wrote: >> On 07/23/2011 11:06 AM, Michael Roth wrote: >>> On 07/23/2011 05:07 AM, Alexander Graf wrote: >>>> >>>> On 20.07.2011, at 22:19, Michael Roth wrote: >>>> >>>>> This is the actual guest daemon, it listens for requests over a >>>>> virtio-serial/isa-serial/unix socket channel and routes them throug= h >>>>> to dispatch routines, and writes the results back to the channel in >>>>> a manner similar to QMP. >>>>> >>>>> A shorthand invocation: >>>>> >>>>> qemu-ga -d >>>>> >>>>> Is equivalent to: >>>>> >>>>> qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.= 0 \ >>>>> -f /var/run/qemu-ga.pid -d >>>>> >>>>> Signed-off-by: Michael Roth >>>> >>>> A rebase on top of current HEAD gave me the following on openSUSE 11= .1 >>>> PPC: >>>> >>>> >>>> agraf@lychee:/home/agraf/release/qemu> make >>>> CC qemu-ga.o >>>> qemu-ga.c:40: error: expected specifier-qualifier-list before =91GSo= cket=92 >> >> GIO is fairly new. It may not be available on openSUSE. >> >> Mike, you probably need to do a configure test for GIO and if it's not >> present, don't build qemu-ga. > > It should've failed the glib probe in that case. I think we might need = a > compile test to catch this GSocket issue. Indeed. Alex, can you help debug this a bit? We can tr to setup a SUSE=20 system. Can you confirm that gio is actually present? Regards, Anthony Liguori > > Rather than building qemu-ga when possible, should we just go ahead and > add a configure option and only run the probes when it's set? At least > until QMP/QEMU start formally using glib? If so, on or off by default? > >> >> Maybe look at just using GIOChannels which have been around much longe= r >> than GSocket. >> > > The GSocket stuff is being used in addition to GIOChannels to handle th= e > listen/accept stuff. I believe we can drop it in favor of > qemu-sockets.c/osdep.c though. > >>>> qga/guest-agent-commands.c: In function =91qmp_guest_fsfreeze_freeze= =92: >>>> qga/guest-agent-commands.c:443: error: =91FIFREEZE=92 undeclared (fi= rst >>>> use in this function) >>>> qga/guest-agent-commands.c:443: error: (Each undeclared identifier i= s >>>> reported only once >>>> qga/guest-agent-commands.c:443: error: for each function it appears >>>> in.) >>>> qga/guest-agent-commands.c: In function =91qmp_guest_fsfreeze_thaw=92= : >>>> qga/guest-agent-commands.c:481: error: =91FITHAW=92 undeclared (firs= t use >>>> in this function) >> >> The kernel probably doesn't implement FIFREEZE. You need to do a >> configure test and set CONFIG_FSFREEZE appropriately. I anticipated th= is >> and that's why I added CONFIG_FSFREEZE and didn't just do __linux__. >> > > Will do, thanks. > >> Regards, >> >> Anthony Liguori >