From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alexander Graf <agraf@suse.de>,
agl@linux.vnet.ibm.com, Michael Roth <mdroth@linux.vnet.ibm.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon
Date: Sat, 23 Jul 2011 21:23:19 +0200 [thread overview]
Message-ID: <4E2B1FA7.6070503@redhat.com> (raw)
In-Reply-To: <4E2AF26C.8040505@redhat.com>
On 07/23/11 18:10, Anthony Liguori wrote:
>
>>> qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_freeze’:
>>> qga/guest-agent-commands.c:443: error: ‘FIFREEZE’ undeclared (first
>>> use in this function)
>>> qga/guest-agent-commands.c:443: error: (Each undeclared identifier is
>>> reported only once
>>> qga/guest-agent-commands.c:443: error: for each function it appears in.)
>>> qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_thaw’:
>>> qga/guest-agent-commands.c:481: error: ‘FITHAW’ undeclared (first use
>>> in this function)
>
> The kernel probably doesn't implement FIFREEZE. You need to do a
> configure test and set CONFIG_FSFREEZE appropriately. I anticipated
> this and that's why I added CONFIG_FSFREEZE and didn't just do __linux__.
That would be odd, FIFREEZE has been around since at least January 2009
according to git blame (fcccf502540e3d752d33b2d8e976034dee81f9f7). Is
OpenSuSE 11 that old?
That said, having a test for it being present is a good idea.
Cheers,
Jes
next prev parent reply other threads:[~2011-07-23 19:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 20:41 [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v8 Michael Roth
2011-07-19 20:41 ` [Qemu-devel] [PATCH v8 1/4] qerror: add QERR_JSON_PARSE_ERROR to qerror.c Michael Roth
2011-07-19 20:41 ` [Qemu-devel] [PATCH v8 2/4] guest agent: command state class Michael Roth
2011-07-19 20:41 ` [Qemu-devel] [PATCH v8 3/4] guest agent: qemu-ga daemon Michael Roth
2011-07-20 17:56 ` Luiz Capitulino
2011-07-20 19:25 ` Michael Roth
2011-07-20 19:31 ` Luiz Capitulino
2011-07-20 20:01 ` Michael Roth
2011-07-20 20:05 ` Michael Roth
2011-07-20 20:12 ` Luiz Capitulino
2011-07-20 20:00 ` [Qemu-devel] [PATCH] guest agent: qemu-ga, remove unused variables Michael Roth
2011-07-20 20:19 ` [Qemu-devel] [PATCH] guest agent: qemu-ga daemon Michael Roth
2011-07-23 10:07 ` Alexander Graf
2011-07-23 10:33 ` Alexander Graf
2011-07-23 16:06 ` Michael Roth
2011-07-23 16:10 ` Anthony Liguori
2011-07-23 19:23 ` Jes Sorensen [this message]
2011-07-23 19:38 ` Alexander Graf
2011-07-23 16:10 ` Anthony Liguori
2011-07-23 16:43 ` Michael Roth
2011-07-23 16:49 ` Anthony Liguori
2011-07-23 18:35 ` Alexander Graf
2011-07-23 19:12 ` Anthony Liguori
2011-07-23 19:20 ` Alexander Graf
2011-07-23 18:34 ` Alexander Graf
2011-07-23 19:14 ` Anthony Liguori
2011-07-23 19:22 ` Alexander Graf
2011-07-23 21:12 ` Anthony Liguori
2011-07-23 21:34 ` Alexander Graf
2011-07-19 20:41 ` [Qemu-devel] [PATCH v8 4/4] guest agent: add guest agent RPCs/commands Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2B1FA7.6070503@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=agl@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).