From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1QkhpE-0008Tt-RO
	for qemu-devel@nongnu.org; Sat, 23 Jul 2011 15:25:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1QkhpD-0005sa-L9
	for qemu-devel@nongnu.org; Sat, 23 Jul 2011 15:25:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43397)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1QkhpD-0005sT-Dq
	for qemu-devel@nongnu.org; Sat, 23 Jul 2011 15:25:23 -0400
Message-ID: <4E2B1FA7.6070503@redhat.com>
Date: Sat, 23 Jul 2011 21:23:19 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1311108115-27128-4-git-send-email-mdroth@linux.vnet.ibm.com>	<1311193177-22282-1-git-send-email-mdroth@linux.vnet.ibm.com>	<81810A74-E616-4199-BB69-E7DE4AAE9C0C@suse.de>
	<4E2AF189.7040403@linux.vnet.ibm.com> <4E2AF26C.8040505@redhat.com>
In-Reply-To: <4E2AF26C.8040505@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alexander Graf <agraf@suse.de>, agl@linux.vnet.ibm.com, Michael Roth <mdroth@linux.vnet.ibm.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@linux.vnet.ibm.com>

On 07/23/11 18:10, Anthony Liguori wrote:
>=20
>>> qga/guest-agent-commands.c: In function =91qmp_guest_fsfreeze_freeze=92=
:
>>> qga/guest-agent-commands.c:443: error: =91FIFREEZE=92 undeclared (fir=
st
>>> use in this function)
>>> qga/guest-agent-commands.c:443: error: (Each undeclared identifier is
>>> reported only once
>>> qga/guest-agent-commands.c:443: error: for each function it appears i=
n.)
>>> qga/guest-agent-commands.c: In function =91qmp_guest_fsfreeze_thaw=92=
:
>>> qga/guest-agent-commands.c:481: error: =91FITHAW=92 undeclared (first=
 use
>>> in this function)
>=20
> The kernel probably doesn't implement FIFREEZE.  You need to do a
> configure test and set CONFIG_FSFREEZE appropriately.  I anticipated
> this and that's why I added CONFIG_FSFREEZE and didn't just do __linux_=
_.

That would be odd, FIFREEZE has been around since at least January 2009
according to git blame (fcccf502540e3d752d33b2d8e976034dee81f9f7). Is
OpenSuSE 11 that old?

That said, having a test for it being present is a good idea.

Cheers,
Jes