From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkjVO-0000H7-8S for qemu-devel@nongnu.org; Sat, 23 Jul 2011 17:13:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkjVN-000849-8O for qemu-devel@nongnu.org; Sat, 23 Jul 2011 17:13:02 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:36698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkjVN-000845-3t for qemu-devel@nongnu.org; Sat, 23 Jul 2011 17:13:01 -0400 Received: by yxt3 with SMTP id 3so2116450yxt.4 for ; Sat, 23 Jul 2011 14:13:00 -0700 (PDT) Message-ID: <4E2B395A.6020708@codemonkey.ws> Date: Sat, 23 Jul 2011 16:12:58 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1311108115-27128-4-git-send-email-mdroth@linux.vnet.ibm.com> <1311193177-22282-1-git-send-email-mdroth@linux.vnet.ibm.com> <81810A74-E616-4199-BB69-E7DE4AAE9C0C@suse.de> <4E2AF189.7040403@linux.vnet.ibm.com> <4E2AF277.6060001@codemonkey.ws> <4E2AFA2D.9070706@linux.vnet.ibm.com> <0651B83D-B47C-4CA1-B6E8-36DB8A5DA00C@suse.de> <4E2B1D93.1090205@codemonkey.ws> <943A9244-2405-4826-9F19-74793D99801E@suse.de> In-Reply-To: <943A9244-2405-4826-9F19-74793D99801E@suse.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: agl@linux.vnet.ibm.com, "qemu-devel@nongnu.org Developers" , Jes Sorensen , Michael Roth , Luiz Capitulino , Blue Swirl On 07/23/2011 02:22 PM, Alexander Graf wrote: > >> We default off'd the I/O thread even after years we still don't have it enabled. >> >> With respect to 0.15, this bit of code is totally isolated from everything else. Worst case scenario, we just disable it on platforms where it doesn't work. It presents no real risk to the stability of the release. > > As you've seen, it can break builds. Why not wait for 0.16? The code came in more than 2 months after the soft feature freeze, which was specifically for big features like this, no? I just sent out a patch that should fix the build issue. Let's see what it takes to resolve this before we talk about disabling for 0.16. Again, there's zero risk to QEMU for having this enabled so if we can resolve the build issues, and I don't see why we can't, then there should be no real problem here. Regards, Anthony Liguori > > Alex >