From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QkkbZ-00058y-Ur
	for qemu-devel@nongnu.org; Sat, 23 Jul 2011 18:23:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QkkbY-0001Sx-Q5
	for qemu-devel@nongnu.org; Sat, 23 Jul 2011 18:23:29 -0400
Received: from mail-pz0-f43.google.com ([209.85.210.43]:62670)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QkkbY-0001Sj-KD
	for qemu-devel@nongnu.org; Sat, 23 Jul 2011 18:23:28 -0400
Received: by pzk1 with SMTP id 1so6161317pzk.30
	for <qemu-devel@nongnu.org>; Sat, 23 Jul 2011 15:23:27 -0700 (PDT)
Message-ID: <4E2B49DB.6020708@codemonkey.ws>
Date: Sat, 23 Jul 2011 17:23:23 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <CAAu8pHtFhHT3M9c3SFzC2RF7GLuyN_4FX-f-Yo8qt+kU+BDCPQ@mail.gmail.com>
In-Reply-To: <CAAu8pHtFhHT3M9c3SFzC2RF7GLuyN_4FX-f-Yo8qt+kU+BDCPQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] slirp: fix warning on mingw32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 07/23/2011 04:25 PM, Blue Swirl wrote:
> Avoid this warning:
>    CC    slirp/ip_icmp.o
> /src/qemu/slirp/ip_icmp.c: In function 'icmp_receive':
> /src/qemu/slirp/ip_icmp.c:418:5: error: passing argument 2 of 'recv'
> from incompatible pointer type [-Werror]
> /usr/local/lib/gcc/i686-mingw32msvc/4.6.0/../../../../i686-mingw32msvc/include/winsock2.h:547:32:
> note: expected 'char *' but argument is of type 'struct icmp *'
>
> Signed-off-by: Blue Swirl<blauwirbel@gmail.com>
> ---
>   slirp/ip_icmp.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c
> index 14a5312..a208648 100644
> --- a/slirp/ip_icmp.c
> +++ b/slirp/ip_icmp.c
> @@ -415,7 +415,7 @@ void icmp_receive(struct socket *so)
>       icp = mtod(m, struct icmp *);
>
>       id = icp->icmp_id;
> -    len = recv(so->s, icp, m->m_len, 0);
> +    len = recv(so->s, (char *)icp, m->m_len, 0);

(char *) is wrong.  recv() takes a void *.

Maybe we need to introduce a qemu_recv?

Regards,

Anthony Liguori

>       icp->icmp_id = id;
>
>       m->m_data -= hlen;