From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QklCV-0004rs-NI for qemu-devel@nongnu.org; Sat, 23 Jul 2011 19:01:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QklCU-00076O-Kt for qemu-devel@nongnu.org; Sat, 23 Jul 2011 19:01:39 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:57322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QklCU-00076K-EP for qemu-devel@nongnu.org; Sat, 23 Jul 2011 19:01:38 -0400 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6NMgaYe015559 for ; Sat, 23 Jul 2011 16:42:36 -0600 Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6NN1bCe200190 for ; Sat, 23 Jul 2011 17:01:37 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6NN7AJe026044 for ; Sat, 23 Jul 2011 17:07:10 -0600 Message-ID: <4E2B52CF.2090706@linux.vnet.ibm.com> Date: Sat, 23 Jul 2011 18:01:35 -0500 From: Michael Roth MIME-Version: 1.0 References: <1311456361-14162-1-git-send-email-aliguori@us.ibm.com> <1311456361-14162-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1311456361-14162-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] guest-agent: only enable FSFREEZE when it's supported by the kernel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Alex Graf On 07/23/2011 04:26 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > qga/guest-agent-commands.c | 12 +++++++----- > 1 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/qga/guest-agent-commands.c b/qga/guest-agent-commands.c > index 624972e..30c4068 100644 > --- a/qga/guest-agent-commands.c > +++ b/qga/guest-agent-commands.c > @@ -10,15 +10,17 @@ > * See the COPYING file in the top-level directory. > */ > > -#if defined(__linux__) > -#define CONFIG_FSFREEZE > -#endif > - > #include > -#if defined(CONFIG_FSFREEZE) > + > +#if defined(__linux__) > #include > #include > + > +#if defined(__linux__)&& defined(FIFREEZE) > +#define CONFIG_FSFREEZE > #endif > +#endif > + > #include > #include > #include "qga/guest-agent-core.h" Much more sensible that the compile test I was doing :)