From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkwTy-0007lk-E6 for qemu-devel@nongnu.org; Sun, 24 Jul 2011 07:04:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkwTx-0004lz-3g for qemu-devel@nongnu.org; Sun, 24 Jul 2011 07:04:26 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:34814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkwTw-0004lv-U2 for qemu-devel@nongnu.org; Sun, 24 Jul 2011 07:04:25 -0400 Message-ID: <4E2BFC35.6040202@mail.berlios.de> Date: Sun, 24 Jul 2011 13:04:21 +0200 From: Stefan Weil MIME-Version: 1.0 References: <4E2BEFFF.5050000@web.de> In-Reply-To: <4E2BEFFF.5050000@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] mingw32: Only link against libiberty if required List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , qemu-devel Am 24.07.2011 12:12, schrieb Jan Kiszka: > From: Jan Kiszka > > Not all (didn't find any) mingw32 cross-toolchains ship a binutils-devel > package, thus lack libiberty.a. According to 08f3896a, -liberty is only > needed for getopt when building for 64 bit. Test for the availability > of a getopt implementation and only pull in libiberty when linking > without it failed. > > Signed-off-by: Jan Kiszka > --- > configure | 11 ++++++++++- > 1 files changed, 10 insertions(+), 1 deletions(-) Hi, I also had problems with some MinGW build environments which don't provide libiberty.a. Debian's gcc-mingw32 cross toolchain which I normally use provides it. libiberty.a not only includes getopt(), but also several other useful functions. Especially ffs() is needed for compilations without optimization and was the main reason for commit 08f3896a. ffs() normally is inline code, and an implementation in QEMU code was removed after 08f3896a. So at least for Debian cross compilation without optimization, your patch will break 32 bit builds because ffs() would be missing. The latest commits to QEMU git master added a lot of new requirements for MinGW builds (glib ...). Maybe some of these also require libiberty.a. Therefore I suggest to wait until git master is working again with MinGW32. Could you describe your build requirements in the QEMU Wiki (http://wiki.qemu.org/Hosts/W32)? Then we can see better how the different needs of native builds and cross builds with different distributions can be met, both for w32 and w64. If there are MinGW (cross) build environments which really don't need libiberty.a, we could modify the check to add linker option -liberty only when the library is available. Kind regards, Stefan Weil