Re: [Qemu-devel] [PATCH 1/7] Export the unassigned_mem read/write functions.

[Anthony Liguori <anthony@codemonkey.ws>]

On 07/23/2011 02:17 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson<rth@twiddle.net>

Why?

Regards,

Anthony Liguori

> ---
>   cpu-common.h |    7 +++++++
>   exec.c       |   12 ++++++------
>   2 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/cpu-common.h b/cpu-common.h
> index 44b04b3..78e1bad 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -56,6 +56,13 @@ static inline void cpu_register_physical_memory(target_phys_addr_t start_addr,
>       cpu_register_physical_memory_offset(start_addr, size, phys_offset, 0);
>   }
>
> +extern CPUReadMemoryFunc unassigned_mem_readb;
> +extern CPUReadMemoryFunc unassigned_mem_readw;
> +extern CPUReadMemoryFunc unassigned_mem_readl;
> +extern CPUWriteMemoryFunc unassigned_mem_writeb;
> +extern CPUWriteMemoryFunc unassigned_mem_writew;
> +extern CPUWriteMemoryFunc unassigned_mem_writel;
> +
>   ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr);
>   ram_addr_t qemu_ram_alloc_from_ptr(DeviceState *dev, const char *name,
>                           ram_addr_t size, void *host);
> diff --git a/exec.c b/exec.c
> index 2160ded..c00badd 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3232,7 +3232,7 @@ ram_addr_t qemu_ram_addr_from_host_nofail(void *ptr)
>       return ram_addr;
>   }
>
> -static uint32_t unassigned_mem_readb(void *opaque, target_phys_addr_t addr)
> +uint32_t unassigned_mem_readb(void *opaque, target_phys_addr_t addr)
>   {
>   #ifdef DEBUG_UNASSIGNED
>       printf("Unassigned mem read " TARGET_FMT_plx "\n", addr);
> @@ -3243,7 +3243,7 @@ static uint32_t unassigned_mem_readb(void *opaque, target_phys_addr_t addr)
>       return 0;
>   }
>
> -static uint32_t unassigned_mem_readw(void *opaque, target_phys_addr_t addr)
> +uint32_t unassigned_mem_readw(void *opaque, target_phys_addr_t addr)
>   {
>   #ifdef DEBUG_UNASSIGNED
>       printf("Unassigned mem read " TARGET_FMT_plx "\n", addr);
> @@ -3254,7 +3254,7 @@ static uint32_t unassigned_mem_readw(void *opaque, target_phys_addr_t addr)
>       return 0;
>   }
>
> -static uint32_t unassigned_mem_readl(void *opaque, target_phys_addr_t addr)
> +uint32_t unassigned_mem_readl(void *opaque, target_phys_addr_t addr)
>   {
>   #ifdef DEBUG_UNASSIGNED
>       printf("Unassigned mem read " TARGET_FMT_plx "\n", addr);
> @@ -3265,7 +3265,7 @@ static uint32_t unassigned_mem_readl(void *opaque, target_phys_addr_t addr)
>       return 0;
>   }
>
> -static void unassigned_mem_writeb(void *opaque, target_phys_addr_t addr, uint32_t val)
> +void unassigned_mem_writeb(void *opaque, target_phys_addr_t addr, uint32_t val)
>   {
>   #ifdef DEBUG_UNASSIGNED
>       printf("Unassigned mem write " TARGET_FMT_plx " = 0x%x\n", addr, val);
> @@ -3275,7 +3275,7 @@ static void unassigned_mem_writeb(void *opaque, target_phys_addr_t addr, uint32_
>   #endif
>   }
>
> -static void unassigned_mem_writew(void *opaque, target_phys_addr_t addr, uint32_t val)
> +void unassigned_mem_writew(void *opaque, target_phys_addr_t addr, uint32_t val)
>   {
>   #ifdef DEBUG_UNASSIGNED
>       printf("Unassigned mem write " TARGET_FMT_plx " = 0x%x\n", addr, val);
> @@ -3285,7 +3285,7 @@ static void unassigned_mem_writew(void *opaque, target_phys_addr_t addr, uint32_
>   #endif
>   }
>
> -static void unassigned_mem_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
> +void unassigned_mem_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
>   {
>   #ifdef DEBUG_UNASSIGNED
>       printf("Unassigned mem write " TARGET_FMT_plx " = 0x%x\n", addr, val);