From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59079)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1Ql3BQ-0005qf-R4
	for qemu-devel@nongnu.org; Sun, 24 Jul 2011 14:13:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1Ql3BQ-0006nD-1t
	for qemu-devel@nongnu.org; Sun, 24 Jul 2011 14:13:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40749)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1Ql3BP-0006n8-Qw
	for qemu-devel@nongnu.org; Sun, 24 Jul 2011 14:13:44 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6OIDgRH009513
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Sun, 24 Jul 2011 14:13:42 -0400
Message-ID: <4E2C6137.6070501@redhat.com>
Date: Sun, 24 Jul 2011 20:15:19 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1311327655-5728-1-git-send-email-hdegoede@redhat.com>
	<20110722122519.GF2483@bow.tlv.redhat.com>
	<4E296FAD.8070101@redhat.com>
In-Reply-To: <4E296FAD.8070101@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev
 open/close events (v3)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Hi,

On 07/22/2011 02:40 PM, Gerd Hoffmann wrote:
>> ACK.
>>
>> Another option would be to not call the state callback for the vdagent
>> subtype from spice-server, because like you say it ignores the continued
>> communication between the agent and the server. Then you could remove
>> the subtype check.
>
> We can even #ifdef the check using SPICE_SERVER_VERSION once the spice-server change is committed, and in a year or so we can raise the minimum required spice-server version and remove some #ifdef clutter.
>

Yeah that is more or less what I proposed in the last mail in the spice-devel
mailinglist thread, I'm glad you agree. I'll prepare a patch to remove
the state calls from the spice-server vdagent handling.

Regards,

Hans