From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ql3rp-00024N-NF for qemu-devel@nongnu.org; Sun, 24 Jul 2011 14:57:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ql3ro-0004wP-KY for qemu-devel@nongnu.org; Sun, 24 Jul 2011 14:57:33 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:48249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ql3ro-0004wL-Gn for qemu-devel@nongnu.org; Sun, 24 Jul 2011 14:57:32 -0400 Received: by gyg8 with SMTP id 8so131350gyg.4 for ; Sun, 24 Jul 2011 11:57:32 -0700 (PDT) Message-ID: <4E2C6B1A.4090804@codemonkey.ws> Date: Sun, 24 Jul 2011 13:57:30 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1310742615-23901-1-git-send-email-pbonzini@redhat.com> <4E21A2B6.50100@codemonkey.ws> <4E2C685D.6010002@redhat.com> In-Reply-To: <4E2C685D.6010002@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] report serial devices created with -device in the PIIX4 config space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, armbru@redhat.com On 07/24/2011 01:45 PM, Paolo Bonzini wrote: > On 07/16/2011 04:39 PM, Anthony Liguori wrote: >> >> Instead of checking for a port assignment, couldn't we do a device tree >> transversal and look for isa-serial devices? We could then look at the >> iobase property to figure out which serial device is configured. > > Thanks for applying it as is It fixes a broken guest so I'm okay with a non-optimal solution. >---BTW, I set to do this first but changed > plans after I noticed that there are no qdev property getters. :-/ I seem to recall a patch to add them but it's not a very nice solution either. Regards, Anthony Liguori > Paolo >