From: Anthony Liguori <anthony@codemonkey.ws>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] report serial devices created with -device in the PIIX4 config space
Date: Sun, 24 Jul 2011 20:45:57 -0500 [thread overview]
Message-ID: <4E2CCAD5.7030904@codemonkey.ws> (raw)
In-Reply-To: <9CC188C2-0991-42C5-A02E-425ED1F5135A@web.de>
On 07/24/2011 04:35 PM, Andreas Färber wrote:
> Am 24.07.2011 um 20:57 schrieb Anthony Liguori:
>
>> On 07/24/2011 01:45 PM, Paolo Bonzini wrote:
>>> On 07/16/2011 04:39 PM, Anthony Liguori wrote:
>>>>
>>>> Instead of checking for a port assignment, couldn't we do a device tree
>>>> transversal and look for isa-serial devices? We could then look at the
>>>> iobase property to figure out which serial device is configured.
>>>
>>> ---BTW, I set to do this first but changed
>>> plans after I noticed that there are no qdev property getters.
>>
>> :-/
>>
>> I seem to recall a patch to add them but it's not a very nice solution
>> either.
>
> Mine, in the ISA/PReP series. The alternative is moving lots of device
> state to header files.
> Adding the getters avoided patch conflicts and seemed cleaner
> symmetry-wise.
The getters lack type safety though which is unfortunate. That said, I
guess it's the best we can do with qdev.
Regards,
Anthony Liguori
>
> Regards,
> Andreas
>
next prev parent reply other threads:[~2011-07-25 1:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 15:10 [Qemu-devel] [PATCH] report serial devices created with -device in the PIIX4 config space Paolo Bonzini
2011-07-15 21:00 ` Andreas Färber
2011-07-23 15:56 ` Anthony Liguori
2011-07-25 9:11 ` Paolo Bonzini
2011-07-16 14:39 ` Anthony Liguori
2011-07-24 18:45 ` Paolo Bonzini
2011-07-24 18:57 ` Anthony Liguori
2011-07-24 21:35 ` Andreas Färber
2011-07-25 1:45 ` Anthony Liguori [this message]
2011-07-25 6:33 ` Paolo Bonzini
2011-07-23 16:14 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2CCAD5.7030904@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=andreas.faerber@web.de \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).