From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlAF8-0005kq-RM for qemu-devel@nongnu.org; Sun, 24 Jul 2011 21:46:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlAF7-0005o8-Pi for qemu-devel@nongnu.org; Sun, 24 Jul 2011 21:46:02 -0400 Received: from mail-pz0-f43.google.com ([209.85.210.43]:36497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlAF7-0005o3-IV for qemu-devel@nongnu.org; Sun, 24 Jul 2011 21:46:01 -0400 Received: by pzk1 with SMTP id 1so7901371pzk.30 for ; Sun, 24 Jul 2011 18:46:00 -0700 (PDT) Message-ID: <4E2CCAD5.7030904@codemonkey.ws> Date: Sun, 24 Jul 2011 20:45:57 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1310742615-23901-1-git-send-email-pbonzini@redhat.com> <4E21A2B6.50100@codemonkey.ws> <4E2C685D.6010002@redhat.com> <4E2C6B1A.4090804@codemonkey.ws> <9CC188C2-0991-42C5-A02E-425ED1F5135A@web.de> In-Reply-To: <9CC188C2-0991-42C5-A02E-425ED1F5135A@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] report serial devices created with -device in the PIIX4 config space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, armbru@redhat.com On 07/24/2011 04:35 PM, Andreas Färber wrote: > Am 24.07.2011 um 20:57 schrieb Anthony Liguori: > >> On 07/24/2011 01:45 PM, Paolo Bonzini wrote: >>> On 07/16/2011 04:39 PM, Anthony Liguori wrote: >>>> >>>> Instead of checking for a port assignment, couldn't we do a device tree >>>> transversal and look for isa-serial devices? We could then look at the >>>> iobase property to figure out which serial device is configured. >>> >>> ---BTW, I set to do this first but changed >>> plans after I noticed that there are no qdev property getters. >> >> :-/ >> >> I seem to recall a patch to add them but it's not a very nice solution >> either. > > Mine, in the ISA/PReP series. The alternative is moving lots of device > state to header files. > Adding the getters avoided patch conflicts and seemed cleaner > symmetry-wise. The getters lack type safety though which is unfortunate. That said, I guess it's the best we can do with qdev. Regards, Anthony Liguori > > Regards, > Andreas >