From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlGoI-0007fA-Fw for qemu-devel@nongnu.org; Mon, 25 Jul 2011 04:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlGoH-0001nS-8T for qemu-devel@nongnu.org; Mon, 25 Jul 2011 04:46:46 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:54123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlGoG-0001dy-So for qemu-devel@nongnu.org; Mon, 25 Jul 2011 04:46:45 -0400 Message-ID: <4E2D2D5C.4060205@adacore.com> Date: Mon, 25 Jul 2011 10:46:20 +0200 From: Elie Richa MIME-Version: 1.0 References: <1311418212-13356-1-git-send-email-agraf@suse.de> <1311418212-13356-6-git-send-email-agraf@suse.de> In-Reply-To: <1311418212-13356-6-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/28] PPC: Set MPIC IDE for IPI to 0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Scott Wood , QEMU-devel Developers On 07/23/2011 12:49 PM, Alexander Graf wrote: > @@ -1304,6 +1304,10 @@ static void mpic_reset (void *opaque) > mpp->src[i].ipvp = 0x80800000; > mpp->src[i].ide = 0x00000001; > } > + /* Set IDE for IPIs to 0 so we don't get spurious interrupts */ > + for (i = mpp->irq_ipi0; i< MAX_IPI; i++) { I suppose you meant i < mpp->irq_ipi0 + MAX_IPI in that loop condition right? ;) > + mpp->src[i].ide = 0; > + } > /* Initialise IRQ destinations */ > for (i = 0; i< MAX_CPU; i++) { > mpp->dst[i].pctp = 0x0000000F;