From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlHzq-0001B8-0C for qemu-devel@nongnu.org; Mon, 25 Jul 2011 06:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlHzp-000621-0H for qemu-devel@nongnu.org; Mon, 25 Jul 2011 06:02:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlHzo-00061q-LG for qemu-devel@nongnu.org; Mon, 25 Jul 2011 06:02:44 -0400 Message-ID: <4E2D3F3E.70303@redhat.com> Date: Mon, 25 Jul 2011 13:02:38 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1311583872-362-1-git-send-email-avi@redhat.com> <4E2D3CC2.7000206@redhat.com> <0AF62DBC-C10D-4C06-9FE3-CCE8AF912462@suse.de> In-Reply-To: <0AF62DBC-C10D-4C06-9FE3-CCE8AF912462@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Maydell , qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/25/2011 12:56 PM, Alexander Graf wrote: > > > > That argument can be used to block any change. You'll get used to it in time. The question is, is the new interface better or not. > > I agree that it keeps you from accidently malloc'ing a struct of pointer size. But couldn't we also just add this to checkpatch.pl? Better APIs trump better patch review. -- error compiling committee.c: too many arguments to function