From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlITN-0003kt-R4 for qemu-devel@nongnu.org; Mon, 25 Jul 2011 06:33:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlITJ-0002id-43 for qemu-devel@nongnu.org; Mon, 25 Jul 2011 06:33:17 -0400 Received: from david.siemens.de ([192.35.17.14]:23249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlITI-0002eH-Kk for qemu-devel@nongnu.org; Mon, 25 Jul 2011 06:33:12 -0400 Message-ID: <4E2D465D.7030502@siemens.com> Date: Mon, 25 Jul 2011 12:33:01 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E2AA4AD.2080608@web.de> <20110725094156.GD21852@amd.home.annexia.org> In-Reply-To: <20110725094156.GD21852@amd.home.annexia.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: Anthony PERARD , Ian Campbell , Anthony Liguori , qemu-devel On 2011-07-25 11:41, Richard W.M. Jones wrote: > On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> -machine somehow suggests that it selects the machine, but it doesn't. >> Fix that before this command is set in stone. >> >> Actually, -machine should supersede -M and allow to introduce arbitrary >> per-machine options to the command line. That will change the internal >> realization again, but we will be able to keep the user interface >> stable. > > This breaks libguestfs which was doing: > > qemu -machine accel=kvm:tcg ... > > We are not passing any -M option at all. We don't particularly care > about the machine type since we're not that performance sensitive and > we don't need to serialize the machine state. > > I have checked, and this works: > > qemu -machine pc,accel=kvm:tcg ... > > "pc" is the default, right? What about for other architectures? Yes, pc is the right default. Other arch have other defaults. > > Please add qemu capabilities, so we can reasonably detect what an > unknown qemu binary supports and so we don't need to do endless > parsing of the -help output and guesswork. This syntax was not yet released (but will be with 0.15, so I was pushing this). Therefore, nothing was "officially" broken by this patch. I'm sorry if you may have released any libguestfs with the transient syntax, but my patches were waiting quite a while for being merged since the introduction of -machine. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux