From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38175)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlMv1-0003GU-Nf
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:18:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlMv0-0002kZ-Os
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:18:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34750)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlMv0-0002kL-EI
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:18:06 -0400
Message-ID: <4E2D8927.50504@redhat.com>
Date: Mon, 25 Jul 2011 18:17:59 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1311602584-23409-1-git-send-email-avi@redhat.com>
	<1311602584-23409-12-git-send-email-avi@redhat.com>
	<alpine.LNX.2.00.1107251915270.3946@linmac>
In-Reply-To: <alpine.LNX.2.00.1107251915270.3946@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 07/25/2011 06:16 PM, malc wrote:
> On Mon, 25 Jul 2011, Avi Kivity wrote:
>
> >  As with the rest of the memory API, the caller associates an eventfd
> >  with an address, and the memory API takes care of registering or
> >  unregistering when the address is made visible or invisible to the
> >  guest.
> >
> >  Signed-off-by: Avi Kivity<avi@redhat.com>
> [..snip..]
>
> >  +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a,
> >  +                                           MemoryRegionIoeventfd b)
> >  +{
> >  +    if (a.addr.start<  b.addr.start) {
> >  +        return true;
> >  +    } else if (a.addr.start>  b.addr.start) {
> >  +        return false;
> >  +    } else if (a.addr.size<  b.addr.size) {
> >  +        return true;
> >  +    } else if (a.addr.size>  b.addr.size) {
> >  +        return false;
> >  +    } else if (a.match_data<  b.match_data) {
> >  +        return true;
> >  +    } else  if (a.match_data>  b.match_data) {
> >  +        return false;
> >  +    } else if (a.match_data) {
> >  +        if (a.data<  b.data) {
> >  +            return true;
> >  +        } else if (a.data>  b.data) {
> >  +            return false;
> >  +        }
> >  +    }
> >  +    if (a.fd<  b.fd) {
> >  +        return true;
> >  +    } else if (a.fd>  b.fd) {
> >  +        return false;
> >  +    }
>
> Braces..
>

Where? add? remove?

-- 
error compiling committee.c: too many arguments to function