From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()
Date: Mon, 25 Jul 2011 17:21:05 +0200 [thread overview]
Message-ID: <4E2D89E1.20401@redhat.com> (raw)
In-Reply-To: <4E2D89C7.8010004@redhat.com>
On 07/25/11 17:20, Avi Kivity wrote:
> On 07/25/2011 06:17 PM, Jes Sorensen wrote:
>> Using the commands consistently does have an impact, and at least with
>> qemu_malloc() it is obvious what they are and how they behave. The
>> proposed macros on the other hand requires everybody to go look up the
>> macro to find out what it is trying to do.
>
> That's true for every single function and macro that qemu defines.
>
Of course, and every time it adds complexity for reading it. In this
particular case it seems to simply make the code worse for no gain.
Jes
next prev parent reply other threads:[~2011-07-25 15:23 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 8:51 [Qemu-devel] [PATCH] Introduce QEMU_NEW() Avi Kivity
2011-07-25 9:32 ` Alexander Graf
2011-07-25 9:37 ` Sasha Levin
2011-07-25 9:43 ` Alexander Graf
2011-07-25 9:49 ` Avi Kivity
2011-07-25 9:48 ` Peter Maydell
2011-07-25 9:52 ` Avi Kivity
2011-07-25 9:56 ` Alexander Graf
2011-07-25 10:02 ` Avi Kivity
2011-07-25 10:04 ` Alexander Graf
2011-07-25 10:09 ` Avi Kivity
2011-07-25 10:19 ` Alexander Graf
2011-07-25 10:46 ` malc
2011-07-25 10:59 ` Markus Armbruster
2011-07-25 11:11 ` Alexander Graf
2011-07-25 12:19 ` Anthony Liguori
2011-07-25 14:16 ` Blue Swirl
2011-07-25 14:20 ` Avi Kivity
2011-07-25 12:30 ` Anthony Liguori
2011-07-25 11:35 ` Avi Kivity
2011-07-25 10:06 ` Stefan Hajnoczi
2011-07-25 10:12 ` Avi Kivity
2011-07-25 10:25 ` Kevin Wolf
2011-07-25 10:28 ` Stefan Hajnoczi
2011-07-25 11:02 ` Markus Armbruster
2011-07-25 11:45 ` Avi Kivity
2011-07-25 15:10 ` Jes Sorensen
2011-07-25 15:15 ` Anthony Liguori
2011-07-25 15:17 ` Jes Sorensen
2011-07-25 15:20 ` Avi Kivity
2011-07-25 15:21 ` Jes Sorensen [this message]
2011-07-25 15:24 ` Avi Kivity
2011-07-25 15:28 ` Jes Sorensen
2011-07-25 15:35 ` Avi Kivity
2011-07-25 12:11 ` Anthony Liguori
2011-07-25 12:18 ` Avi Kivity
2011-07-25 12:21 ` Anthony Liguori
2011-07-25 12:41 ` Avi Kivity
2011-07-25 14:23 ` Blue Swirl
2011-07-25 14:25 ` Anthony Liguori
2011-07-25 14:30 ` Max Filippov
2011-07-25 14:43 ` Anthony Liguori
2011-07-25 14:47 ` malc
2011-07-25 14:50 ` Avi Kivity
2011-07-25 14:58 ` malc
2011-07-25 14:59 ` Avi Kivity
2011-07-25 14:51 ` Paolo Bonzini
2011-07-25 14:56 ` Blue Swirl
2011-07-25 15:21 ` Paolo Bonzini
2011-08-01 10:49 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2D89E1.20401@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).