From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlMzx-0000Rx-Sw for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:23:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlMzw-0003Wz-NW for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:23:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlMzw-0003Wv-EE for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:23:12 -0400 Message-ID: <4E2D89E1.20401@redhat.com> Date: Mon, 25 Jul 2011 17:21:05 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1311583872-362-1-git-send-email-avi@redhat.com> <4E2D876C.3010300@redhat.com> <4E2D8896.7070100@codemonkey.ws> <4E2D8904.5080200@redhat.com> <4E2D89C7.8010004@redhat.com> In-Reply-To: <4E2D89C7.8010004@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Stefan Hajnoczi , kvm@vger.kernel.org, qemu-devel@nongnu.org On 07/25/11 17:20, Avi Kivity wrote: > On 07/25/2011 06:17 PM, Jes Sorensen wrote: >> Using the commands consistently does have an impact, and at least with >> qemu_malloc() it is obvious what they are and how they behave. The >> proposed macros on the other hand requires everybody to go look up the >> macro to find out what it is trying to do. > > That's true for every single function and macro that qemu defines. > Of course, and every time it adds complexity for reading it. In this particular case it seems to simply make the code worse for no gain. Jes