From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QlMyL-00075j-0O
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:21:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QlMyJ-00035W-WF
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:21:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4974)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QlMyJ-00035O-K3
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:21:31 -0400
Message-ID: <4E2D89F6.7060908@redhat.com>
Date: Mon, 25 Jul 2011 17:21:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1311583872-362-1-git-send-email-avi@redhat.com>
	<4E2D5D7C.40208@codemonkey.ws> <4E2D5F0D.2040303@redhat.com>
	<4E2D5FB3.7000906@codemonkey.ws>
	<CAAu8pHs_cx5GzNO2J=ZRf7QBTQ1qKratc-f8VxuRQSnrQ8Pb0g@mail.gmail.com>
	<4E2D82EF.4020606@redhat.com>
	<CAAu8pHuoW0zxRS6XMAfqbsKpFLUgtuOQU1ftP19DhVU++Uedyw@mail.gmail.com>
In-Reply-To: <CAAu8pHuoW0zxRS6XMAfqbsKpFLUgtuOQU1ftP19DhVU++Uedyw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On 07/25/2011 04:56 PM, Blue Swirl wrote:
> > qemu_malloc uses g_malloc => you keep tracepoints, you just do not trace
> > memory allocated by glib
>
> Unless the plan is to replace all qemu_malloc() calls with calls to g_malloc().

We can worry when the day comes... there is already another task 
blocking that replacement (balancing qemu_malloc with qemu_free).

> >  The former is much less code, however it requires qemu_malloc to be always
> >  balanced with qemu_free (patches ready and on my github tree, won't be sent
> >  before KVM Forum though...).
>
> Freeing qemu_malloc() memory with plain free() is a bug.

We have many bugs, then. :)

Paolo