From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlNJS-0003sN-1v
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:43:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlNJR-0006zj-2J
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:43:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26721)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlNJQ-0006zd-OM
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:43:20 -0400
Message-ID: <4E2D8F10.9070009@redhat.com>
Date: Mon, 25 Jul 2011 18:43:12 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1311602584-23409-1-git-send-email-avi@redhat.com>
	<1311602584-23409-12-git-send-email-avi@redhat.com>
	<alpine.LNX.2.00.1107251915270.3946@linmac>
	<4E2D8927.50504@redhat.com>
	<alpine.LNX.2.00.1107251921560.4044@linmac>
	<4E2D8B97.5040407@redhat.com>
	<alpine.LNX.2.00.1107251937240.4246@linmac>
In-Reply-To: <alpine.LNX.2.00.1107251937240.4246@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 07/25/2011 06:38 PM, malc wrote:
> On Mon, 25 Jul 2011, Avi Kivity wrote:
>
> >  On 07/25/2011 06:22 PM, malc wrote:
> >  >  >   >   >    +    }
> >  >  >   >   >    +    if (a.fd<    b.fd) {
> >  >  >   >   >    +        return true;
> >  >  >   >   >    +    } else {
> >  >                  if (a.fd>    b.fd) {
> >  >      >   >   >    +        return false;
> >  >      >   >   >    +    }
> >  >               }
> >
> >  CODING_STYLE permits braceless else if.
>
> The example uses it, the text however suggests it's illegal.

I'll post a patch.  It's perfectly reasonable IMO, and there ~1800 
instances in the tree.

-- 
error compiling committee.c: too many arguments to function