From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlQDd-0000a4-M3 for qemu-devel@nongnu.org; Mon, 25 Jul 2011 14:49:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlQDc-0002AM-JF for qemu-devel@nongnu.org; Mon, 25 Jul 2011 14:49:33 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:65442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlQDc-0002AI-Fa for qemu-devel@nongnu.org; Mon, 25 Jul 2011 14:49:32 -0400 Received: by yia25 with SMTP id 25so2895044yia.4 for ; Mon, 25 Jul 2011 11:49:32 -0700 (PDT) Message-ID: <4E2DBAB9.1070804@codemonkey.ws> Date: Mon, 25 Jul 2011 13:49:29 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-5-git-send-email-avi@redhat.com> In-Reply-To: <1311602584-23409-5-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/23] Internal interfaces for memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/25/2011 09:02 AM, Avi Kivity wrote: > get_system_memory() provides the root of the memory hierarchy. > > This interface is intended to be private between memory.c and exec.c. > If this file is included elsewhere, it should be regarded as a bug (or > TODO item). However, it will be temporarily needed for the conversion > to hierarchical memory routing. > > Signed-off-by: Avi Kivity > --- > exec-memory.h | 23 +++++++++++++++++++++++ > memory.c | 7 +++++++ > 2 files changed, 30 insertions(+), 0 deletions(-) > create mode 100644 exec-memory.h > > diff --git a/exec-memory.h b/exec-memory.h > new file mode 100644 > index 0000000..7eb9085 > --- /dev/null > +++ b/exec-memory.h > @@ -0,0 +1,23 @@ Please add a copyright/license. Otherwise, Reviewed-by: Anthony Liguori Regards, Anthony Liguori > +#ifndef EXEC_MEMORY_H > +#define EXEC_MEMORY_H > + > +/* > + * Internal interfaces between memory.c/exec.c/vl.c. Do not #include unless > + * you're one of them. > + */ > + > +#include "memory.h" > + > +#ifndef CONFIG_USER_ONLY > + > +/* Get the root memory region. This interface should only be used temporarily > + * until a proper bus interface is available. > + */ > +MemoryRegion *get_system_memory(void); > + > +/* Set the root memory region. This region is the system memory map. */ > +void set_system_memory_map(MemoryRegion *mr); > + > +#endif > + > +#endif > diff --git a/memory.c b/memory.c > index 339bea3..48470d2 100644 > --- a/memory.c > +++ b/memory.c > @@ -12,6 +12,7 @@ > */ > > #include "memory.h" > +#include "exec-memory.h" > #include > > typedef struct AddrRange AddrRange; > @@ -698,3 +699,9 @@ void memory_region_del_subregion(MemoryRegion *mr, > QTAILQ_REMOVE(&mr->subregions, subregion, subregions_link); > memory_region_update_topology(); > } > + > +void set_system_memory_map(MemoryRegion *mr) > +{ > + root_memory_region = mr; > + memory_region_update_topology(); > +}