From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qle3I-0001cd-O8 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 05:35:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qle3H-0003Es-Qk for qemu-devel@nongnu.org; Tue, 26 Jul 2011 05:35:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qle3H-0003Ei-I4 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 05:35:47 -0400 Message-ID: <4E2E8A6D.3070902@redhat.com> Date: Tue, 26 Jul 2011 12:35:41 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-2-git-send-email-avi@redhat.com> <4E2DB8C2.7040802@codemonkey.ws> In-Reply-To: <4E2DB8C2.7040802@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/23] Hierarchical memory region API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/25/2011 09:41 PM, Anthony Liguori wrote: >> +/* Initialize a memory region >> + * >> + * The region typically acts as a container for other memory regions. >> + */ > > > I'm also writing a fair bit of documentation right now. We should use > a common format and declare that the doc format in CODING_STYLE. > > I think the two choices are gtk-doc (which I have been using): > > I think gtk-doc is more concise and easier to write. But Doxygen > clearly has better tooling. Updated to use gtk-doc. Ugh, a large API. > > Otherwise, Reviewed-by: Anthony Liguori but not > tested yet. > > I assume that all of the FIXMEs don't actually introduce regressions, > right? Not intentionally. -- error compiling committee.c: too many arguments to function