From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlf6w-0003t9-SC for qemu-devel@nongnu.org; Tue, 26 Jul 2011 06:43:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qlf6w-0000Md-3z for qemu-devel@nongnu.org; Tue, 26 Jul 2011 06:43:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlf6v-0000MU-SA for qemu-devel@nongnu.org; Tue, 26 Jul 2011 06:43:38 -0400 Message-ID: <4E2E9A53.4060402@redhat.com> Date: Tue, 26 Jul 2011 13:43:31 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-13-git-send-email-avi@redhat.com> <4E2DC00D.5080608@codemonkey.ws> In-Reply-To: <4E2DC00D.5080608@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/23] memory: separate building the final memory map into two steps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/25/2011 10:12 PM, Anthony Liguori wrote: > On 07/25/2011 09:02 AM, Avi Kivity wrote: >> Instead of adding and deleting regions in one pass, do a delete >> pass followed by an add pass. This fixes the following case: >> >> from: >> 0x0000-0x0fff ram (a1) >> 0x1000-0x1fff mmio (a2) >> 0x2000-0x2fff ram (a3) >> >> to: >> 0x0000-0x2fff ram (b1) >> >> The single pass algorithm removed a1, added b2, then removed a2 and a2, > > You mean a2 and a3 I suppose? Yes; fixed. -- error compiling committee.c: too many arguments to function