From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlfIx-0000nw-4A for qemu-devel@nongnu.org; Tue, 26 Jul 2011 06:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlfIw-0002XL-76 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 06:56:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlfIw-0002XF-0C for qemu-devel@nongnu.org; Tue, 26 Jul 2011 06:56:02 -0400 Message-ID: <4E2E9D3C.60603@redhat.com> Date: Tue, 26 Jul 2011 13:55:56 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-16-git-send-email-avi@redhat.com> <4E2DC14E.5080408@codemonkey.ws> In-Reply-To: <4E2DC14E.5080408@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/23] exec.c: initialize memory map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/25/2011 10:17 PM, Anthony Liguori wrote: >> +static void memory_map_init(void) >> +{ >> + system_memory = qemu_malloc(sizeof(*system_memory)); >> + memory_region_init(system_memory, "system", UINT64_MAX); > > > Would be nice to #define MEM_REG_SIZE_ALL UINT64_MAX > > Without reading the docs, it seems like an odd bit of code otherwise. It's really temporary. It should come from the machine description and specify the processor's system bus width. -- error compiling committee.c: too many arguments to function