From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43961)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlfPf-0003uv-4y
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:03:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlfPe-000415-7r
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:02:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17532)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QlfPd-00040z-Vd
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:02:58 -0400
Message-ID: <4E2E9EDC.8020908@redhat.com>
Date: Tue, 26 Jul 2011 14:02:52 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1311602584-23409-1-git-send-email-avi@redhat.com>
	<1311602584-23409-20-git-send-email-avi@redhat.com>
	<4E2DCBE1.8030209@codemonkey.ws>
In-Reply-To: <4E2DCBE1.8030209@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 19/23] pc: move global memory map out of
 pc_init1() and into its callers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 07/25/2011 11:02 PM, Anthony Liguori wrote:
> On 07/25/2011 09:03 AM, Avi Kivity wrote:
>> Signed-off-by: Avi Kivity<avi@redhat.com>
>
> What's the rationale here?

Removing globals and making dependencies explicit.

-- 
error compiling committee.c: too many arguments to function