From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36571)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Qlfwf-000673-5X
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:37:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Qlfwe-00025M-8l
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:37:05 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:63084)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Qlfwe-00025G-6H
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:37:04 -0400
Received: by yxt3 with SMTP id 3so216842yxt.4
	for <qemu-devel@nongnu.org>; Tue, 26 Jul 2011 04:37:03 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E2EA6DA.4000006@redhat.com>
Date: Tue, 26 Jul 2011 13:36:58 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1311679582-11211-1-git-send-email-avi@redhat.com>
	<1311679582-11211-5-git-send-email-avi@redhat.com>
In-Reply-To: <1311679582-11211-5-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments
 of a single memory region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 07/26/2011 01:26 PM, Avi Kivity wrote:
> +    while (i < view->nr) {
> +        j = i + 1;
> +        while (j < view->nr
> +               && can_merge(&view->ranges[j-1], &view->ranges[j])) {
> +            view->ranges[i].addr.size += view->ranges[j].addr.size;
> +            ++j;
> +        }
> +        ++i;

if (j != i) {

> +        memmove(&view->ranges[i], &view->ranges[j],
> +                (view->nr - j) * sizeof(view->ranges[j]));
> +        view->nr -= j - i;
> +    }

}


Paolo