From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39126)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QlgAk-0006NX-19
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:51:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QlgAi-0005A3-JU
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:51:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1QlgAi-00059Z-CS
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:51:36 -0400
Message-ID: <4E2EAA44.105@redhat.com>
Date: Tue, 26 Jul 2011 13:51:32 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1311679582-11211-1-git-send-email-avi@redhat.com>
	<1311679582-11211-5-git-send-email-avi@redhat.com>
	<4E2EA6DA.4000006@redhat.com> <4E2EA71A.7000106@redhat.com>
In-Reply-To: <4E2EA71A.7000106@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments
 of a single memory region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 07/26/2011 01:38 PM, Avi Kivity wrote:
>>
>> if (j != i) {
>>
>>> +        memmove(&view->ranges[i], &view->ranges[j],
>>> +                (view->nr - j) * sizeof(view->ranges[j]));
>>> +        view->nr -= j - i;
>>> +    }
>>
>> }
>
> Seems to work both ways?

Sure, but you're pointlessly memmove-ing memory over itself.  I'm not 
sure how many segments a single memory region will usually have, but 
it's better to be safe.

Paolo