qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, libvir-list@redhat.com,
	Corey Bryant <coreyb@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, tchicks@us.ibm.com
Subject: Re: [Qemu-devel] [libvirt] [PATCH v3] Add support for fd: protocol
Date: Tue, 26 Jul 2011 08:02:02 -0600	[thread overview]
Message-ID: <4E2EC8DA.4090303@redhat.com> (raw)
In-Reply-To: <20110726130211.GA2853@lst.de>

On 07/26/2011 07:02 AM, Christoph Hellwig wrote:
> I have to say I really hate it.  We've been working hard on getting rid
> of special cases in the qemu block layer, and this sprinkles them all
> over.  I'd recommend to fix your security model instead.

What is it that you hate - the particular qemu implementation expressed 
by this patch (in which case, we're all ears for a better 
implementation), or the need for fd passing (which libvirt is strongly 
in favor of, and which there really is no other way to fix the security 
model to work well with file systems like NFS that lack per-file 
labels)?  In my mind, increased security trumps poor aesthetics - if the 
patch really does make it possible to enhance security, then the special 
casing to support the patch is worth it.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

  parent reply	other threads:[~2011-07-26 14:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 12:51 [Qemu-devel] [PATCH v3] Add support for fd: protocol Corey Bryant
2011-07-26 13:02 ` Christoph Hellwig
2011-07-26 13:15   ` Corey Bryant
2011-07-26 14:02   ` Eric Blake [this message]
2011-07-26 14:05   ` Kevin Wolf
2011-07-26 14:46     ` Corey Bryant
2011-07-26 14:54       ` Kevin Wolf
2011-07-26 14:00 ` [Qemu-devel] [libvirt] " Eric Blake
2011-07-26 14:19   ` Kevin Wolf
2011-07-26 15:18 ` [Qemu-devel] " Kevin Wolf
2011-07-26 16:57   ` Corey Bryant
2011-07-26 17:10     ` Alexander Graf
2011-07-26 19:00       ` Corey Bryant
2011-07-27  8:11     ` Kevin Wolf
2011-07-27  8:22       ` Daniel P. Berrange
2011-07-27  8:36         ` Kevin Wolf
2011-07-27  8:43           ` Daniel P. Berrange
2011-07-27 13:09             ` Corey Bryant
2011-07-27 14:57               ` Kevin Wolf
2011-07-27 21:36 ` Blue Swirl
2011-08-11 16:28 ` Corey Bryant
2011-08-12 10:07   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2EC8DA.4090303@redhat.com \
    --to=eblake@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=coreyb@linux.vnet.ibm.com \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tchicks@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).