From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: libvir-list@redhat.com, aliguori@us.ibm.com,
Corey Bryant <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, tchicks@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3] Add support for fd: protocol
Date: Tue, 26 Jul 2011 16:05:42 +0200 [thread overview]
Message-ID: <4E2EC9B6.8060105@redhat.com> (raw)
In-Reply-To: <20110726130211.GA2853@lst.de>
Am 26.07.2011 15:02, schrieb Christoph Hellwig:
> I have to say I really hate it. We've been working hard on getting rid
> of special cases in the qemu block layer, and this sprinkles them all
> over. I'd recommend to fix your security model instead.
I think the problem here is more with the implementation that with the
intention.
I agree that you just can't do this. A patch adding support for a fd:
protocol should touch block/fd.c and nothing else. You can add some
supporting patches that extend the generic block layer to support e.g.
formats that can't reopen. However, if you touch the code of other block
drivers, you're doing it wrong.
Kevin
next prev parent reply other threads:[~2011-07-26 14:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 12:51 [Qemu-devel] [PATCH v3] Add support for fd: protocol Corey Bryant
2011-07-26 13:02 ` Christoph Hellwig
2011-07-26 13:15 ` Corey Bryant
2011-07-26 14:02 ` [Qemu-devel] [libvirt] " Eric Blake
2011-07-26 14:05 ` Kevin Wolf [this message]
2011-07-26 14:46 ` [Qemu-devel] " Corey Bryant
2011-07-26 14:54 ` Kevin Wolf
2011-07-26 14:00 ` [Qemu-devel] [libvirt] " Eric Blake
2011-07-26 14:19 ` Kevin Wolf
2011-07-26 15:18 ` [Qemu-devel] " Kevin Wolf
2011-07-26 16:57 ` Corey Bryant
2011-07-26 17:10 ` Alexander Graf
2011-07-26 19:00 ` Corey Bryant
2011-07-27 8:11 ` Kevin Wolf
2011-07-27 8:22 ` Daniel P. Berrange
2011-07-27 8:36 ` Kevin Wolf
2011-07-27 8:43 ` Daniel P. Berrange
2011-07-27 13:09 ` Corey Bryant
2011-07-27 14:57 ` Kevin Wolf
2011-07-27 21:36 ` Blue Swirl
2011-08-11 16:28 ` Corey Bryant
2011-08-12 10:07 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2EC9B6.8060105@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tchicks@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).