From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QljlU-00027x-4L
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:41:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QljlT-0002H9-EZ
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:41:48 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:59275)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1QljlT-0002Gq-A1
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:41:47 -0400
Received: by qyk10 with SMTP id 10so1673640qyk.4
	for <qemu-devel@nongnu.org>; Tue, 26 Jul 2011 08:41:46 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E2EE036.30606@twiddle.net>
Date: Tue, 26 Jul 2011 08:41:42 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1311679582-11211-1-git-send-email-avi@redhat.com>
	<1311679582-11211-5-git-send-email-avi@redhat.com>
	<4E2EA6DA.4000006@redhat.com>
In-Reply-To: <4E2EA6DA.4000006@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments
 of a single memory region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On 07/26/2011 04:36 AM, Paolo Bonzini wrote:
> On 07/26/2011 01:26 PM, Avi Kivity wrote:
>> +    while (i < view->nr) {
>> +        j = i + 1;
>> +        while (j < view->nr
>> +               && can_merge(&view->ranges[j-1], &view->ranges[j])) {
>> +            view->ranges[i].addr.size += view->ranges[j].addr.size;
>> +            ++j;
>> +        }
>> +        ++i;
> 
> if (j != i) {
> 
>> +        memmove(&view->ranges[i], &view->ranges[j],
>> +                (view->nr - j) * sizeof(view->ranges[j]));
>> +        view->nr -= j - i;
>> +    }
> 
> }

Err, j = i + 1, and increments.  Your conditional will always be true.


r~