From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qlk7z-000150-Jf
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 12:05:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qlk7s-0007GN-1e
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 12:05:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56285)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Qlk7r-0007GD-Qu
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 12:04:56 -0400
Message-ID: <4E2EE5A2.7070605@redhat.com>
Date: Tue, 26 Jul 2011 19:04:50 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1311679582-11211-1-git-send-email-avi@redhat.com>
	<1311679582-11211-5-git-send-email-avi@redhat.com>
	<4E2EA6DA.4000006@redhat.com> <4E2EE036.30606@twiddle.net>
In-Reply-To: <4E2EE036.30606@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments
 of a single memory region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 07/26/2011 06:41 PM, Richard Henderson wrote:
> On 07/26/2011 04:36 AM, Paolo Bonzini wrote:
> >  On 07/26/2011 01:26 PM, Avi Kivity wrote:
> >>  +    while (i<  view->nr) {
> >>  +        j = i + 1;
> >>  +        while (j<  view->nr
> >>  +&&  can_merge(&view->ranges[j-1],&view->ranges[j])) {
> >>  +            view->ranges[i].addr.size += view->ranges[j].addr.size;
> >>  +            ++j;
> >>  +        }
> >>  +        ++i;
> >
> >  if (j != i) {
> >
> >>  +        memmove(&view->ranges[i],&view->ranges[j],
> >>  +                (view->nr - j) * sizeof(view->ranges[j]));
> >>  +        view->nr -= j - i;
> >>  +    }
> >
> >  }
>
> Err, j = i + 1, and increments.  Your conditional will always be true.
>

If the while loop body is never executed, then i will equal j (both 
incremented once).

-- 
error compiling committee.c: too many arguments to function