From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52513)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Qm3e1-0007Ww-AV
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 08:55:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Qm3e0-0005d7-D4
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 08:55:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49819)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Qm3e0-0005d3-3b
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 08:55:24 -0400
Message-ID: <4E300B64.8030905@redhat.com>
Date: Wed, 27 Jul 2011 14:58:12 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1311005222-31060-1-git-send-email-stefano.stabellini@eu.citrix.com>
	<4E300823.9000408@suse.de>
In-Reply-To: <4E300823.9000408@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RESEND v3] xen: implement unplug protocol
 in xen_platform
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: xen-devel@lists.xensource.com, mst@redhat.com, stefano.stabellini@eu.citrix.com, armbru@redhat.com, qemu-devel@nongnu.org, anthony.perard@citrix.com

Am 27.07.2011 14:44, schrieb Alexander Graf:
> On 07/18/2011 06:07 PM, stefano.stabellini@eu.citrix.com wrote:
>> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>
>> The unplug protocol is necessary to support PV drivers in the guest: the
>> drivers expect to be able to "unplug" emulated disks and nics before
>> initializing the Xen PV interfaces.
>> It is responsibility of the guest to make sure that the unplug is done
>> before the emulated devices or the PV interface start to be used.
>>
>> We use pci_for_each_device to walk the PCI bus, identify the devices and
>> disks that we want to disable and dynamically unplug them.
>>
>> Changes in v2:
>>
>> - use PCI_CLASS constants;
>>
>> - replace pci_unplug_device with qdev_unplug;
>>
>> - do not import hw/ide/internal.h in xen_platform.c;
>>
>>
>> Changes in v3:
>>
>> - introduce piix3-ide-xen, that support hot-unplug;
>>
>> - move the unplug code to hw/ide/piix.c;
>>
>> - just call qdev_unplug from xen_platform.c to unplug the IDE disks;
>>
>> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> 
> Kevin, please ack.

Trivial rebase of the version I already acked.

Acked-by: Kevin Wolf <kwolf@redhat.com>