From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm48K-0008KT-Pd for qemu-devel@nongnu.org; Wed, 27 Jul 2011 09:26:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qm48J-0003J1-RZ for qemu-devel@nongnu.org; Wed, 27 Jul 2011 09:26:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51822 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm48J-0003Gm-Mi for qemu-devel@nongnu.org; Wed, 27 Jul 2011 09:26:43 -0400 Message-ID: <4E301211.10407@suse.de> Date: Wed, 27 Jul 2011 15:26:41 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1311005222-31060-1-git-send-email-stefano.stabellini@eu.citrix.com> <4E300823.9000408@suse.de> <4E300B64.8030905@redhat.com> In-Reply-To: <4E300B64.8030905@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RESEND v3] xen: implement unplug protocol in xen_platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: xen-devel@lists.xensource.com, mst@redhat.com, stefano.stabellini@eu.citrix.com, armbru@redhat.com, qemu-devel@nongnu.org, anthony.perard@citrix.com On 07/27/2011 02:58 PM, Kevin Wolf wrote: > Am 27.07.2011 14:44, schrieb Alexander Graf: >> On 07/18/2011 06:07 PM, stefano.stabellini@eu.citrix.com wrote: >>> From: Stefano Stabellini >>> >>> The unplug protocol is necessary to support PV drivers in the guest: the >>> drivers expect to be able to "unplug" emulated disks and nics before >>> initializing the Xen PV interfaces. >>> It is responsibility of the guest to make sure that the unplug is done >>> before the emulated devices or the PV interface start to be used. >>> >>> We use pci_for_each_device to walk the PCI bus, identify the devices and >>> disks that we want to disable and dynamically unplug them. >>> >>> Changes in v2: >>> >>> - use PCI_CLASS constants; >>> >>> - replace pci_unplug_device with qdev_unplug; >>> >>> - do not import hw/ide/internal.h in xen_platform.c; >>> >>> >>> Changes in v3: >>> >>> - introduce piix3-ide-xen, that support hot-unplug; >>> >>> - move the unplug code to hw/ide/piix.c; >>> >>> - just call qdev_unplug from xen_platform.c to unplug the IDE disks; >>> >>> Signed-off-by: Stefano Stabellini >> Kevin, please ack. > Trivial rebase of the version I already acked. Thanks :). Applied to the xen-next branch. Alex