From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QmBij-0002aX-M6
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 17:32:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QmBii-0004ww-Jz
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 17:32:49 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:53956)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QmBii-0004wp-3O
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 17:32:48 -0400
Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com
	[9.17.195.226])
	by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6RLDdaZ009141
	for <qemu-devel@nongnu.org>; Wed, 27 Jul 2011 15:13:39 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p6RLWkrj199930
	for <qemu-devel@nongnu.org>; Wed, 27 Jul 2011 15:32:46 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p6RFWFxP018885
	for <qemu-devel@nongnu.org>; Wed, 27 Jul 2011 09:32:16 -0600
Message-ID: <4E3083F9.20205@us.ibm.com>
Date: Wed, 27 Jul 2011 16:32:41 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1311725174-9635-1-git-send-email-aliguori@us.ibm.com>	<CAAu8pHukksrVC-7DN_Vm-7EM4o-y-ZQKJAN6hbkR7rwQEr2b-g@mail.gmail.com>	<4E307999.9080603@us.ibm.com>	<CAAu8pHuTq+qTH2ZCwK0BtkALjXrD1pUTLh-Y_XmpUyhm8eKTFA@mail.gmail.com>
	<4E308155.1040300@mail.berlios.de>
In-Reply-To: <4E308155.1040300@mail.berlios.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Amit Shah <amit.shah@redhat.com>, Hans de Goede <hdegoede@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On 07/27/2011 04:21 PM, Stefan Weil wrote:
> NDEBUG is normally set automatically for production code,
> and it disables assertions which is not always good.
>
> Assertions are useful even in production code unless
> you are sure that the code is bug free or the assertions
> cost to much resources - either memory or execution time.
>
> I don't think this is the case for QEMU, therefore I'd prefer
> having assertions in production code, too. This simply
> means undefining NDEBUG before including assert.h.

I don't know what constitutes "production builds" but the software that 
most people use in production (normal distributions packages) don't 
define NDEBUG.

Regards,

Anthony Liguori

>
> Regards,
> Stefan
>