From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmKwM-0005fb-BE for qemu-devel@nongnu.org; Thu, 28 Jul 2011 03:23:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmKwL-0001AL-9r for qemu-devel@nongnu.org; Thu, 28 Jul 2011 03:23:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmKwL-0001AB-1e for qemu-devel@nongnu.org; Thu, 28 Jul 2011 03:23:29 -0400 Message-ID: <4E310E6A.6000004@redhat.com> Date: Thu, 28 Jul 2011 10:23:22 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20110727154229.656532d4@doriath> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] Introduce vm_stop_permanent() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Jan Kiszka , qemu-devel , Luiz Capitulino On 07/28/2011 12:44 AM, Blue Swirl wrote: > On Wed, Jul 27, 2011 at 9:42 PM, Luiz Capitulino wrote: > > This function should be used when the VM is not supposed to resume > > execution (eg. by issuing 'cont' monitor command). > > > > Today, we allow the user to resume execution even when: > > > > o the guest shuts down and -no-shutdown is used > > o there's a kvm internal error > > o loading the VM state with -loadvm or "loadvm" in the monitor fails > > > > I think only badness can happen from the cases above. > > I'd suppose a system_reset should bring the system back to sanity and > then clear vm_permanent_stopped (where's -ly?) except maybe for KVM > internal error if that can't be recovered. Then it would not very > permanent anymore, so the name would need adjusting. Currently, all kvm internal errors are recoverable by reset (and possibly by fiddling with memory/registers). -- error compiling committee.c: too many arguments to function