From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmNpI-000858-IH for qemu-devel@nongnu.org; Thu, 28 Jul 2011 06:28:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmNpH-00060P-Bd for qemu-devel@nongnu.org; Thu, 28 Jul 2011 06:28:24 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:53942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmNp0-0005v6-SW for qemu-devel@nongnu.org; Thu, 28 Jul 2011 06:28:23 -0400 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp03.in.ibm.com (8.14.4/8.13.1) with ESMTP id p6SARqjI004875 for ; Thu, 28 Jul 2011 15:57:52 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6SARpGo2429034 for ; Thu, 28 Jul 2011 15:57:52 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6SARpxw022817 for ; Thu, 28 Jul 2011 15:57:51 +0530 Message-ID: <4E313C6D.7000203@in.ibm.com> Date: Thu, 28 Jul 2011 16:09:41 +0530 From: Supriya Kannery MIME-Version: 1.0 References: <20110727113000.25109.16204.sendpatchset@skannery> <20110727113014.25109.58868.sendpatchset@skannery> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V5 Patch 1/4]Qemu: Enhance "info block" to display host cache setting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Supriya Kannery , qemu-devel@nongnu.org, Christoph Hellwig On 07/27/2011 07:49 PM, Stefan Hajnoczi wrote: > On Wed, Jul 27, 2011 at 12:30 PM, Supriya Kannery > wrote: >> Enhance "info block" to display hostcache setting for each >> block device. >> >> Example: >> (qemu) info block >> ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2 >> encrypted=0 >> >> Enhanced to display "hostcache" setting: >> (qemu) info block >> ide0-hd0: type=hd removable=0 hostcache=true file=../rhel6-32.qcow2 >> ro=0 drv=qcow2 encrypted=0 > > This description is outdated, should be hostcache=1 instead of hostcache=true. > >> @@ -1749,13 +1757,18 @@ void bdrv_info(Monitor *mon, QObject **r >> QObject *bs_obj; >> >> bs_obj = qobject_from_jsonf("{ 'device': %s, 'type': 'unknown', " >> - "'removable': %i, 'locked': %i }", >> - bs->device_name, bs->removable, >> - bs->locked); >> + "'removable': %i, 'locked': %i, " >> + "'hostcache': %s }", >> + bs->device_name, bs->removable, >> + bs->locked, >> + (bs->open_flags& BDRV_O_NOCACHE) ? >> + "false" : "true"); > > Please use the same bool-from-int format specifier ('%i') as the other > fields for consistency. The value can be !(bs->open_flags& > BDRV_O_NOCACHE). > ok >> + >> + QDict *bs_dict = qobject_to_qdict(bs_obj); >> + qdict_put(bs_dict, "open_flags", qint_from_int(bs->open_flags)); >> >> if (bs->drv) { >> QObject *obj; >> - QDict *bs_dict = qobject_to_qdict(bs_obj); >> >> obj = qobject_from_jsonf("{ 'file': %s, 'ro': %i, 'drv': %s, " >> "'encrypted': %i }", > > My copy of the code has the following a few lines further down: > qdict_put_obj(bs_dict, "inserted", obj); > > Removing bs_dict would break the build. Am I missing something? > qdict_put_obj() for "inserted" is still there further down in the code. Here, QDict *bs_dict = qobject_to_qdict(bs_obj); is moved up to enable placing of "open_flags" into the dict. We need "open_flags" in dict to calculate hostcache value for printing in monitor. Code for placing "inserted" is not touched. >> Index: qemu/qmp-commands.hx >> =================================================================== >> --- qemu.orig/qmp-commands.hx >> +++ qemu/qmp-commands.hx >> @@ -1131,6 +1131,7 @@ Each json-object contain the following: >> - Possible values: "unknown" >> - "removable": true if the device is removable, false otherwise (json-bool) >> - "locked": true if the device is locked, false otherwise (json-bool) >> +- "hostcache": true if hostcache enabled, false otherwise (json-bool) > > Let's explain what "hostcache" means: > > - "hostcache": true if host page cache is enabled, false otherwise (json-bool) > ok -Thanks, Supriya > Stefan