From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Frediano Ziglio <freddy77@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Odd code in cpus.c
Date: Fri, 29 Jul 2011 10:51:12 +0200 [thread overview]
Message-ID: <4E327480.4040806@redhat.com> (raw)
In-Reply-To: <4E3273FD.1020007@siemens.com>
On 07/29/2011 10:49 AM, Jan Kiszka wrote:
>> >
>> > which seems to set kvm signal twice with same values (taking into
>> > account that in kvm_set_signal_mask the set is copied before the call
>> > to kvm_vcpu_ioctl).
> Indeed. Harmless fortunately. I suspect the duplicate bits in the #ifdef
> CONFIG_IOTHREAD block were simply forgotten. Paolo?
Yes, perhaps a rebase conflict was resolved erroneously. Can probably
get in via qemu-trivial.
Paolo
prev parent reply other threads:[~2011-07-29 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 8:34 [Qemu-devel] Odd code in cpus.c Frediano Ziglio
2011-07-29 8:49 ` Jan Kiszka
2011-07-29 8:51 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E327480.4040806@redhat.com \
--to=pbonzini@redhat.com \
--cc=freddy77@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).