From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qmims-00064W-Hb for qemu-devel@nongnu.org; Fri, 29 Jul 2011 04:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qmimr-0002C2-Ih for qemu-devel@nongnu.org; Fri, 29 Jul 2011 04:51:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qmimr-0002By-99 for qemu-devel@nongnu.org; Fri, 29 Jul 2011 04:51:17 -0400 Message-ID: <4E327480.4040806@redhat.com> Date: Fri, 29 Jul 2011 10:51:12 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <4E3273FD.1020007@siemens.com> In-Reply-To: <4E3273FD.1020007@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Odd code in cpus.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Frediano Ziglio , qemu-devel On 07/29/2011 10:49 AM, Jan Kiszka wrote: >> > >> > which seems to set kvm signal twice with same values (taking into >> > account that in kvm_set_signal_mask the set is copied before the call >> > to kvm_vcpu_ioctl). > Indeed. Harmless fortunately. I suspect the duplicate bits in the #ifdef > CONFIG_IOTHREAD block were simply forgotten. Paolo? Yes, perhaps a rebase conflict was resolved erroneously. Can probably get in via qemu-trivial. Paolo