* [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c
@ 2011-07-26 14:33 Stefan Berger
2011-07-26 14:38 ` Peter Maydell
2011-07-29 14:38 ` Anthony Liguori
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Berger @ 2011-07-26 14:33 UTC (permalink / raw)
To: aliguori, qemu-trivial; +Cc: qemu-devel@nongnu.org
This patch fixes a compilation error in xen-mapcache.c .
/home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’:
/home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
---
xen-mapcache.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: qemu-git/xen-mapcache.c
===================================================================
--- qemu-git.orig/xen-mapcache.c
+++ qemu-git/xen-mapcache.c
@@ -237,7 +237,7 @@ uint8_t *xen_map_cache(target_phys_addr_
ram_addr_t xen_ram_addr_from_mapcache(void *ptr)
{
- MapCacheEntry *entry = NULL, *pentry = NULL;
+ MapCacheEntry *entry = NULL;
MapCacheRev *reventry;
target_phys_addr_t paddr_index;
target_phys_addr_t size;
@@ -263,7 +263,6 @@ ram_addr_t xen_ram_addr_from_mapcache(vo
entry = &mapcache->entry[paddr_index % mapcache->nr_buckets];
while (entry && (entry->paddr_index != paddr_index || entry->size != size)) {
- pentry = entry;
entry = entry->next;
}
if (!entry) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c
2011-07-26 14:33 [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c Stefan Berger
@ 2011-07-26 14:38 ` Peter Maydell
2011-07-26 14:45 ` Stefan Berger
2011-07-29 14:38 ` Anthony Liguori
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2011-07-26 14:38 UTC (permalink / raw)
To: Stefan Berger; +Cc: qemu-trivial, aliguori, qemu-devel@nongnu.org
On 26 July 2011 15:33, Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
> This patch fixes a compilation error in xen-mapcache.c .
>
> /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’:
> /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
Juan posted a fix for this back on the 11th:
http://patchwork.ozlabs.org/patch/104254/
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c
2011-07-26 14:38 ` Peter Maydell
@ 2011-07-26 14:45 ` Stefan Berger
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Berger @ 2011-07-26 14:45 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, aliguori, qemu-devel@nongnu.org
On 07/26/2011 10:38 AM, Peter Maydell wrote:
> On 26 July 2011 15:33, Stefan Berger<stefanb@linux.vnet.ibm.com> wrote:
>> This patch fixes a compilation error in xen-mapcache.c .
>>
>> /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’:
>> /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ set but not used [-Werror=unused-but-set-variable]
>> cc1: all warnings being treated as errors
> Juan posted a fix for this back on the 11th:
>
> http://patchwork.ozlabs.org/patch/104254/
>
Then I can only emphasize the importance of this patch.
Stefan
> -- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c
2011-07-26 14:33 [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c Stefan Berger
2011-07-26 14:38 ` Peter Maydell
@ 2011-07-29 14:38 ` Anthony Liguori
1 sibling, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2011-07-29 14:38 UTC (permalink / raw)
To: Stefan Berger; +Cc: qemu-trivial, qemu-devel@nongnu.org
On 07/26/2011 09:33 AM, Stefan Berger wrote:
> This patch fixes a compilation error in xen-mapcache.c .
>
> /home/stefanb/qemu/qemu-git/xen-mapcache.c: In function ‘xen_ram_addr_from_mapcache’:
> /home/stefanb/qemu/qemu-git/xen-mapcache.c:240:42: error: variable ‘pentry’ set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Stefan Berger<stefanb@linux.vnet.ibm.com>
Applied. Thanks.
Regards,
Anthony Liguori
>
> ---
> xen-mapcache.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: qemu-git/xen-mapcache.c
> ===================================================================
> --- qemu-git.orig/xen-mapcache.c
> +++ qemu-git/xen-mapcache.c
> @@ -237,7 +237,7 @@ uint8_t *xen_map_cache(target_phys_addr_
>
> ram_addr_t xen_ram_addr_from_mapcache(void *ptr)
> {
> - MapCacheEntry *entry = NULL, *pentry = NULL;
> + MapCacheEntry *entry = NULL;
> MapCacheRev *reventry;
> target_phys_addr_t paddr_index;
> target_phys_addr_t size;
> @@ -263,7 +263,6 @@ ram_addr_t xen_ram_addr_from_mapcache(vo
>
> entry =&mapcache->entry[paddr_index % mapcache->nr_buckets];
> while (entry&& (entry->paddr_index != paddr_index || entry->size != size)) {
> - pentry = entry;
> entry = entry->next;
> }
> if (!entry) {
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-29 14:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-26 14:33 [Qemu-devel] [PATCH] Fix a compilation error in xen-mapcache.c Stefan Berger
2011-07-26 14:38 ` Peter Maydell
2011-07-26 14:45 ` Stefan Berger
2011-07-29 14:38 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).