From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmoNB-0002g1-MT for qemu-devel@nongnu.org; Fri, 29 Jul 2011 10:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmoNA-0000QB-Bx for qemu-devel@nongnu.org; Fri, 29 Jul 2011 10:49:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmoNA-0000Q7-3F for qemu-devel@nongnu.org; Fri, 29 Jul 2011 10:49:08 -0400 Message-ID: <4E32C85E.1070900@redhat.com> Date: Fri, 29 Jul 2011 16:49:02 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1309448777-1447-1-git-send-email-pbonzini@redhat.com> <4E32B246.6060001@codemonkey.ws> In-Reply-To: <4E32B246.6060001@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: quintela@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On 07/29/2011 03:14 PM, Anthony Liguori wrote: > I really hate the idea of changing the migration format moments before > the release. So do I, but that's life. > Since subsections are optional, can't we take the offending subsections, > remove them, bump the section version numbers and make the fields required? The bug happens when you migrate from 0.15 to 0.15, and 0.14 didn't have any subsection for that device. This happens pretty much in all cases that were added to 0.15. It quickly makes a bigger patch than this one, and actually one that's harder to review. At least with this one things can only go _royally_ wrong, and any serious automated test would catch it. Paolo