From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qmp04-0003fu-Bv for qemu-devel@nongnu.org; Fri, 29 Jul 2011 11:29:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qmp03-0008KY-9m for qemu-devel@nongnu.org; Fri, 29 Jul 2011 11:29:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qmp03-0008KS-2k for qemu-devel@nongnu.org; Fri, 29 Jul 2011 11:29:19 -0400 Message-ID: <4E32D277.1020901@redhat.com> Date: Fri, 29 Jul 2011 17:32:07 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1311783711-8129-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <4E32AD3A.4010601@redhat.com> <87fwlp17x1.fsf@skywalker.in.ibm.com> In-Reply-To: <87fwlp17x1.fsf@skywalker.in.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH -V2] coroutine: Add CoRwlock support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org Am 29.07.2011 16:24, schrieb Aneesh Kumar K.V: > On Fri, 29 Jul 2011 14:53:14 +0200, Kevin Wolf wrote: >> Am 27.07.2011 18:21, schrieb Aneesh Kumar K.V: >>> Signed-off-by: Aneesh Kumar K.V >>> --- >>> qemu-coroutine-lock.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ >>> qemu-coroutine.h | 12 ++++++++++++ >>> 2 files changed, 56 insertions(+), 0 deletions(-) >> >> Looks good to me. >> >> What's your plan with getting this merged? Are you going to just include >> it with another series that you'll send once the basic coroutine support >> is in? > > Since the patch already is dependent on CoQueue, it would be nice if you > can push it through your tree. I will stage the dependent VirtFS patch > after that get merged upstream. Okay, I applied it to my branch so that I won't forget about it, but while merging I noticed two things that you could fix: The patch adds an #include "qemu-thread.h" to qemu-coroutine.h for apparently no reason, and it would be nice to have comments in qemu-coroutine.h like all other functions have. Kevin