qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/9] usb-wacom doesn't support migration
Date: Fri, 29 Jul 2011 17:57:33 +0200	[thread overview]
Message-ID: <4E32D86D.3020106@redhat.com> (raw)
In-Reply-To: <1311156579-9814-7-git-send-email-kraxel@redhat.com>

On 07/20/2011 12:09 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   hw/usb-wacom.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/usb-wacom.c b/hw/usb-wacom.c
> index 9d348e1..d76ee97 100644
> --- a/hw/usb-wacom.c
> +++ b/hw/usb-wacom.c
> @@ -349,6 +349,11 @@ static int usb_wacom_initfn(USBDevice *dev)
>       return 0;
>   }
>
> +static const VMStateDescription vmstate_usb_wacom = {
> +    .name = "usb-wacom",
> +    .unmigratable = 1,
> +};
> +
>   static struct USBDeviceInfo wacom_info = {
>       .product_desc   = "QEMU PenPartner Tablet",
>       .qdev.name      = "usb-wacom-tablet",
> @@ -356,6 +361,7 @@ static struct USBDeviceInfo wacom_info = {
>       .usbdevice_name = "wacom-tablet",
>       .usb_desc       =&desc_wacom,
>       .qdev.size      = sizeof(USBWacomState),
> +    .qdev.vmsd      =&vmstate_usb_wacom,
>       .init           = usb_wacom_initfn,
>       .handle_packet  = usb_generic_handle_packet,
>       .handle_reset   = usb_wacom_handle_reset,

Since usb_wacom does not support auto-wakeup, it should actually kinda 
sorta work like usb-tablet used to, right?

Paolo

  reply	other threads:[~2011-07-29 15:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 10:09 [Qemu-devel] [PULL] non-migratable devices Gerd Hoffmann
2011-07-20 10:09 ` [Qemu-devel] [PATCH 1/9] vmstate: add no_migrate flag to VMStateDescription Gerd Hoffmann
2011-07-20 10:09 ` [Qemu-devel] [PATCH 2/9] vmstate: complain about devices without vmstate Gerd Hoffmann
2011-07-20 12:40   ` Peter Maydell
2011-07-20 12:51     ` Gerd Hoffmann
2011-07-20 10:09 ` [Qemu-devel] [PATCH 3/9] ahci doesn't support migration Gerd Hoffmann
2011-07-20 10:09 ` [Qemu-devel] [PATCH 4/9] ehci " Gerd Hoffmann
2011-07-20 10:09 ` [Qemu-devel] [PATCH 5/9] usb storage: first migration support bits Gerd Hoffmann
2011-07-29 15:56   ` Paolo Bonzini
2011-07-20 10:09 ` [Qemu-devel] [PATCH 6/9] usb-wacom doesn't support migration Gerd Hoffmann
2011-07-29 15:57   ` Paolo Bonzini [this message]
2011-07-20 10:09 ` [Qemu-devel] [PATCH 7/9] usb-bt " Gerd Hoffmann
2011-07-20 10:09 ` [Qemu-devel] [PATCH 8/9] usb-net " Gerd Hoffmann
2011-07-20 10:09 ` [Qemu-devel] [PATCH 9/9] usb-serial " Gerd Hoffmann
2011-07-22 14:21 ` [Qemu-devel] [PULL] non-migratable devices Anthony Liguori
2011-07-22 14:32   ` Gerd Hoffmann
2011-07-29 15:46 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E32D86D.3020106@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).