From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44120)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QmpRS-0001sS-S0
	for qemu-devel@nongnu.org; Fri, 29 Jul 2011 11:57:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QmpRR-0006ZM-IK
	for qemu-devel@nongnu.org; Fri, 29 Jul 2011 11:57:38 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:56174)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QmpRR-0006ZI-Fl
	for qemu-devel@nongnu.org; Fri, 29 Jul 2011 11:57:37 -0400
Received: by yia25 with SMTP id 25so3146072yia.4
	for <qemu-devel@nongnu.org>; Fri, 29 Jul 2011 08:57:36 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E32D86D.3020106@redhat.com>
Date: Fri, 29 Jul 2011 17:57:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1311156579-9814-1-git-send-email-kraxel@redhat.com>
	<1311156579-9814-7-git-send-email-kraxel@redhat.com>
In-Reply-To: <1311156579-9814-7-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/9] usb-wacom doesn't support migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/20/2011 12:09 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   hw/usb-wacom.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/usb-wacom.c b/hw/usb-wacom.c
> index 9d348e1..d76ee97 100644
> --- a/hw/usb-wacom.c
> +++ b/hw/usb-wacom.c
> @@ -349,6 +349,11 @@ static int usb_wacom_initfn(USBDevice *dev)
>       return 0;
>   }
>
> +static const VMStateDescription vmstate_usb_wacom = {
> +    .name = "usb-wacom",
> +    .unmigratable = 1,
> +};
> +
>   static struct USBDeviceInfo wacom_info = {
>       .product_desc   = "QEMU PenPartner Tablet",
>       .qdev.name      = "usb-wacom-tablet",
> @@ -356,6 +361,7 @@ static struct USBDeviceInfo wacom_info = {
>       .usbdevice_name = "wacom-tablet",
>       .usb_desc       =&desc_wacom,
>       .qdev.size      = sizeof(USBWacomState),
> +    .qdev.vmsd      =&vmstate_usb_wacom,
>       .init           = usb_wacom_initfn,
>       .handle_packet  = usb_generic_handle_packet,
>       .handle_reset   = usb_wacom_handle_reset,

Since usb_wacom does not support auto-wakeup, it should actually kinda 
sorta work like usb-tablet used to, right?

Paolo