From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wolfgang.mauerer@siemens.com>) id 1Qn3pm-0007KN-18
	for qemu-devel@nongnu.org; Sat, 30 Jul 2011 03:19:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wolfgang.mauerer@siemens.com>) id 1Qn3pk-0000oE-Ds
	for qemu-devel@nongnu.org; Sat, 30 Jul 2011 03:19:41 -0400
Received: from lizzard.sbs.de ([194.138.37.39]:15172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wolfgang.mauerer@siemens.com>) id 1Qn3pk-0000o0-6B
	for qemu-devel@nongnu.org; Sat, 30 Jul 2011 03:19:40 -0400
Message-ID: <4E33B0CE.6050300@siemens.com>
Date: Sat, 30 Jul 2011 09:20:46 +0200
From: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
MIME-Version: 1.0
References: <1311972045-5644-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1311972045-5644-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: Fix bad shell expression for
	non-Linux hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On 29/07/11 22:40, Stefan Weil wrote:
> With vhost_net="" (most non-Linux hosts), configure prints an
> error message:
> 
> test: 2551: =: unexpected operator
> 
> Fix this and similar code by adding the missing "".
> 
> Cc: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
> Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
good catch, I've tested the code only on Linux hosts.

Cheers, Wolfgang
> ---
>  configure |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure b/configure
> index b582f5e..001208d 100755
> --- a/configure
> +++ b/configure
> @@ -2521,7 +2521,7 @@ fi
>  # __sync_fetch_and_and requires at least -march=i486. Many toolchains
>  # use i686 as default anyway, but for those that don't, an explicit
>  # specification is necessary
> -if test $vhost_net = "yes" && test $cpu = "i386"; then
> +if test "$vhost_net" = "yes" && test "$cpu" = "i386"; then
>    cat > $TMPC << EOF
>  int sfaa(unsigned *ptr)
>  {
> @@ -2700,7 +2700,7 @@ echo "nss used          $smartcard_nss"
>  echo "usb net redir     $usb_redir"
>  echo "OpenGL support    $opengl"
>  
> -if test $sdl_too_old = "yes"; then
> +if test "$sdl_too_old" = "yes"; then
>  echo "-> Your SDL version is too old - please upgrade to have SDL support"
>  fi
>  
> @@ -2788,7 +2788,7 @@ fi
>  if test "$static" = "yes" ; then
>    echo "CONFIG_STATIC=y" >> $config_host_mak
>  fi
> -if test $profiler = "yes" ; then
> +if test "$profiler" = "yes" ; then
>    echo "CONFIG_PROFILER=y" >> $config_host_mak
>  fi
>  if test "$slirp" = "yes" ; then
> @@ -3342,7 +3342,7 @@ case "$target_arch2" in
>        \( "$target_arch2" = "x86_64" -a "$cpu" = "i386"   \) -o \
>        \( "$target_arch2" = "i386"   -a "$cpu" = "x86_64" \) \) ; then
>        echo "CONFIG_KVM=y" >> $config_target_mak
> -      if test $vhost_net = "yes" ; then
> +      if test "$vhost_net" = "yes" ; then
>          echo "CONFIG_VHOST_NET=y" >> $config_target_mak
>        fi
>      fi