From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 01/15] sdl: Fix termination in -no-shutdown mode
Date: Sat, 30 Jul 2011 07:57:42 -0500 [thread overview]
Message-ID: <4E33FFC6.7010807@codemonkey.ws> (raw)
In-Reply-To: <328490ad2c7aeb3ebf2404264b36368ce06e8579.1312018756.git.jan.kiszka@web.de>
On 07/30/2011 04:39 AM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> Just like the monitor does, we need to clear no_shutdown before calling
> qemu_system_shutdown_request on quit requests. Otherwise, QEMU just
> stops the VM.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
> ---
> ui/sdl.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/ui/sdl.c b/ui/sdl.c
> index 6dbc5cb..9efcda5 100644
> --- a/ui/sdl.c
> +++ b/ui/sdl.c
> @@ -672,8 +672,10 @@ static void sdl_refresh(DisplayState *ds)
> sdl_process_key(&ev->key);
> break;
> case SDL_QUIT:
> - if (!no_quit)
> + if (!no_quit) {
> + no_shutdown = 0;
> qemu_system_shutdown_request();
> + }
> break;
> case SDL_MOUSEMOTION:
> if (gui_grab || kbd_mouse_is_absolute() ||
next prev parent reply other threads:[~2011-07-30 12:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 9:39 [Qemu-devel] [PATCH 00/15] sdl: Usability improvements Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 01/15] sdl: Fix termination in -no-shutdown mode Jan Kiszka
2011-07-30 12:57 ` Anthony Liguori [this message]
2011-07-30 9:39 ` [Qemu-devel] [PATCH 02/15] sdl: Do not make full screen mode resizable Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 03/15] sdl: Avoid redundant scaling deactivation Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 04/15] sdl: Properly mark modifier+u as hotkey Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 05/15] sdl: Fix full screen toggling from scaled mode Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 06/15] sdl: Restore scaling mode on return from full screen Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 07/15] sdl: Drop bogus gui_fullscreen_initial_grab Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 08/15] sdl: Initialize gui_fullscreen earlier during setup Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 09/15] sdl: Consistently avoid grabbing input for text consoles Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 10/15] sdl: Never release input while in full screen mode Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 11/15] sdl: Fix cursor handling when switching consoles in absolute mouse mode Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 12/15] sdl: Dynamically grab input " Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 13/15] sdl: Add zoom hot keys Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 14/15] sdl: Factor out event handlers from sdl_refresh Jan Kiszka
2011-07-30 9:39 ` [Qemu-devel] [PATCH 15/15] sdl: Refactor sdl_send_mouse_event Jan Kiszka
2011-08-01 0:28 ` [Qemu-devel] [PATCH 00/15] sdl: Usability improvements Anthony Liguori
2011-08-05 16:47 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E33FFC6.7010807@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).